public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jens Gehrlein <sew_s@tqs.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] 83xx: fix CFG_ENV_ADDR and CFG_ENV_SECT_SIZE	definitions
Date: Wed, 31 Oct 2007 16:47:13 +0100	[thread overview]
Message-ID: <4728A381.8090400@tqs.de> (raw)
In-Reply-To: <11938442162401-git-send-email-timur@freescale.com>

Timur Tabi wrote:
> Fix the definitions of CFG_ENV_ADDR and CFG_ENV_SECT_SIZE for all the 83xx
> boards.  This change guarantees that the environment will be located on
> the first flash sector after the U-Boot image.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>

> +	#define CFG_ENV_ADDR		(CFG_MONITOR_BASE + CFG_MONITOR_LEN)

Hi Timur,

IMHO this would work only if the sum of
CFG_MONITOR_BASE + CFG_MONITOR_LEN is sector aligned.
Did you set CFG_MONITOR_LEN appropriately?
(Just to avoid unexpected behaviour)

Best regards
   Jens

  reply	other threads:[~2007-10-31 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 15:23 [U-Boot-Users] 83xx: fix CFG_ENV_ADDR and CFG_ENV_SECT_SIZE definitions Timur Tabi
2007-10-31 15:47 ` Jens Gehrlein [this message]
2007-10-31 15:49   ` Timur Tabi
2007-10-31 16:14     ` Jens Gehrlein
2007-11-03 21:49 ` Wolfgang Denk
2007-11-04 15:26   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4728A381.8090400@tqs.de \
    --to=sew_s@tqs.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox