From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Gehrlein <sew_s@tqs.de>
Date: Wed, 31 Oct 2007 16:47:13 +0100
Subject: [U-Boot-Users] 83xx: fix CFG_ENV_ADDR and
	CFG_ENV_SECT_SIZE	definitions
In-Reply-To: <11938442162401-git-send-email-timur@freescale.com>
References: <11938442162401-git-send-email-timur@freescale.com>
Message-ID: <4728A381.8090400@tqs.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Timur Tabi wrote:
> Fix the definitions of CFG_ENV_ADDR and CFG_ENV_SECT_SIZE for all the 83xx
> boards.  This change guarantees that the environment will be located on
> the first flash sector after the U-Boot image.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>

> +	#define CFG_ENV_ADDR		(CFG_MONITOR_BASE + CFG_MONITOR_LEN)

Hi Timur,

IMHO this would work only if the sum of
CFG_MONITOR_BASE + CFG_MONITOR_LEN is sector aligned.
Did you set CFG_MONITOR_LEN appropriately?
(Just to avoid unexpected behaviour)

Best regards
   Jens