From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Gehrlein <sew_s@tqs.de>
Date: Wed, 31 Oct 2007 17:14:00 +0100
Subject: [U-Boot-Users] 83xx: fix CFG_ENV_ADDR and
	CFG_ENV_SECT_SIZE	definitions
In-Reply-To: <4728A415.3040800@freescale.com>
References: <11938442162401-git-send-email-timur@freescale.com>
	<4728A381.8090400@tqs.de> <4728A415.3040800@freescale.com>
Message-ID: <4728A9C8.50300@tqs.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Timur Tabi wrote:
> Jens Gehrlein wrote:
> 
>> IMHO this would work only if the sum of
>> CFG_MONITOR_BASE + CFG_MONITOR_LEN is sector aligned.
>> Did you set CFG_MONITOR_LEN appropriately?
>> (Just to avoid unexpected behaviour)
> 
> I'm under the assumption that CFG_MONITOR_LEN is always supposed to be a 
> multiple of the sector size.  Should I add comments to the header files 
> to state that explicitly?
> 
It's just, because I saw implementations, where CFG_MONITOR_LEN was an
arbitrary value. It depends on how the developer interpretes this
define and how it is used in the cpu and board specific code.

Maybe a comment would help, but I leave the decision to you.

Best regards
   Jens