public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Larry Johnson <lrj@arlinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2 (resubmit)] NET: Cosmetic changes
Date: Sun, 04 Nov 2007 18:27:47 -0500	[thread overview]
Message-ID: <472E5573.70500@arlinx.com> (raw)
In-Reply-To: <20071103215652.6DCC724756@gemini.denx.de>

Wolfgang Denk wrote:
> In message <4728AB89.80205@arlinx.com> you wrote:
>> -	int (* read)(char *devname, unsigned char addr,
>> -			unsigned char reg, unsigned short *value);
>> -	int (* write)(char *devname, unsigned char addr,
>> -			unsigned char reg, unsigned short value);
> 
> The old code used TAB for indentation. Good.
> 
>> +	int (*read) (char *devname, unsigned char addr,
>> +		     unsigned char reg, unsigned short *value);
>> +	int (*write) (char *devname, unsigned char addr,
>> +		      unsigned char reg, unsigned short value);
> 
> Now you add to the file size by indeting with characters which is,
> strictly speaking, a violation of the Coding Style).
> 
> 
> Best regards,
> 
> Wolfgang Denk

Hi Wolfgang,

Unfortunately, it was "Lindent" that broke the indentation.  Apparently,
when a parameter list to a function call doesn't fit on a line, it tries
to line up additional parameters beneath the first one.

I could search for and fix these cases, but it would defeat the purpose
of posting these cosmetic changes, which was so that the next time
someone uses "Lindent" on the file to check modifications, he or she
won't get a bunch of changes to the unmodified parts of the code.

Best regards,
Larry

  reply	other threads:[~2007-11-04 23:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 16:21 [U-Boot-Users] [PATCH 1/2 (resubmit)] NET: Cosmetic changes Larry Johnson
2007-11-03 21:56 ` Wolfgang Denk
2007-11-04 23:27   ` Larry Johnson [this message]
2007-11-05  5:45     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472E5573.70500@arlinx.com \
    --to=lrj@arlinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox