[U-Boot-Users] What if eth_init() fails?

[Ben Warren <bwarren@qstreams.com>]

Hi Upakul,

Upakul Barkakaty wrote:
> Hi all, I observed that when the Ethernet initialization fails, it is 
> not properly halting the operation and exiting. On walking through the 
> Networking files, I saw that the eth_init() in eth.c either returns a 
> 0 or 1. Now, in the NetLoop() in net.c file, from where the eth_init() 
> gets called, checks the condition if (eth_init(bd) < 0) { eth_halt(); 
> return(-1); } which is thus never true. Thus the network operation, 
> never exits gracefully, if Ethernet init fails. Any of you, have any 
> clues about this??
> ------------------------------------------------------------------------
> View this message in context: What if eth_init() fails? 
> <http://www.nabble.com/What-if-eth_init%28%29-fails--tf4802433.html#a13740586>
> Sent from the Uboot - Users mailing list archive 
> <http://www.nabble.com/Uboot---Users-f553.html> at Nabble.com.
You are correct.  If you send a patch, I'll incorporate it.

regards,
Ben