[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Jon Loeliger]

From: Roy Zang <tie-fei.zang@freescale.com>

Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
Acked-by: Jon Loeliger <jdl@freescale.com>
---
 include/configs/MPC8610HPCD.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/configs/MPC8610HPCD.h b/include/configs/MPC8610HPCD.h
index f5d9c09..ef1310f 100644
--- a/include/configs/MPC8610HPCD.h
+++ b/include/configs/MPC8610HPCD.h
@@ -312,16 +312,16 @@
 #define CONFIG_PCI_SCAN_SHOW		/* show pci devices on startup */
 
 #define CONFIG_NET_MULTI
+#define CONFIG_CMD_NET
 #define CONFIG_PCI_PNP		/* do pci plug-and-play */
 
-#if 0 /* TODO */
-/* enable onboard uli network support */
-#endif
-
 #define CONFIG_RTL8139
 #define CONFIG_SK98
 #define CONFIG_EEPRO100
 #define CONFIG_TULIP
+#ifdef CONFIG_TULIP
+#define CONFIG_ETHADDR   00:E0:0C:00:00:01
+#endif
 
 /************************************************************
  * USB support
-- 
1.5.3

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Ben Warren]

Jon Loeliger wrote:
> From: Roy Zang <tie-fei.zang@freescale.com>
>
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> Acked-by: Jon Loeliger <jdl@freescale.com>
> ---
>  include/configs/MPC8610HPCD.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>   
<snip>
>  #define CONFIG_EEPRO100
>  #define CONFIG_TULIP
> +#ifdef CONFIG_TULIP
> +#define CONFIG_ETHADDR   00:E0:0C:00:00:01
>   
Do you really need to do this? It's just asking for trouble.

regards,
Ben

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Zang Roy-r61911]

On Wed, 2007-11-14 at 05:37, Ben Warren wrote:
> Jon Loeliger wrote:
> > From: Roy Zang <tie-fei.zang@freescale.com>
> >
> > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> > Acked-by: Jon Loeliger <jdl@freescale.com>
> > ---
> >  include/configs/MPC8610HPCD.h |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> >   
> <snip>
> >  #define CONFIG_EEPRO100
> >  #define CONFIG_TULIP
> > +#ifdef CONFIG_TULIP
> > +#define CONFIG_ETHADDR   00:E0:0C:00:00:01
> >   
> Do you really need to do this? It's just asking for trouble.
It can assign a init MAC address to the port.
Now, EEPROM issue is solved. We can remove it.
CONFIG_TULIP is not accurate for the port. I have 
renamed it to CONFIG_ULI526X in the driver.
I will provide a patch to fix both of these.
Tired today :-), hope tomorrow!
Thanks.
Roy  

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Ben Warren]

Zang Roy-r61911 wrote:
> On Wed, 2007-11-14 at 05:37, Ben Warren wrote:
>   
>> Jon Loeliger wrote:
>>     
>>> From: Roy Zang <tie-fei.zang@freescale.com>
>>>
>>> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
>>> Acked-by: Jon Loeliger <jdl@freescale.com>
>>> ---
>>>  include/configs/MPC8610HPCD.h |    8 ++++----
>>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>>   
>>>       
>> <snip>
>>     
>>>  #define CONFIG_EEPRO100
>>>  #define CONFIG_TULIP
>>> +#ifdef CONFIG_TULIP
>>> +#define CONFIG_ETHADDR   00:E0:0C:00:00:01
>>>   
>>>       
>> Do you really need to do this? It's just asking for trouble.
>>     
> It can assign a init MAC address to the port.
> Now, EEPROM issue is solved. We can remove it.
> CONFIG_TULIP is not accurate for the port. I have 
> renamed it to CONFIG_ULI526X in the driver.
> I will provide a patch to fix both of these.
> Tired today :-), hope tomorrow!
> Thanks.
> Roy  
>
>
>   
Sounds good.  Sleep > work.

regards,
Ben

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Timur Tabi]

Jon Loeliger wrote:
> From: Roy Zang <tie-fei.zang@freescale.com>
> 
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> Acked-by: Jon Loeliger <jdl@freescale.com>
> ---

No commit message?

>  #define CONFIG_RTL8139
>  #define CONFIG_SK98
>  #define CONFIG_EEPRO100
>  #define CONFIG_TULIP

Shouldn't we undefine these macros?  With the on-board ULI working now, we don't 
need these other NICs.

-- 
Timur Tabi
Linux kernel developer at Freescale

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Jon Loeliger]

Timur Tabi wrote:
>
> No commit message?

When will people figure this out?

The mail Subject: line _is_ the first line of
the commit log message.

Thanks,
jdl

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Timur Tabi]

Jon Loeliger wrote:

> The mail Subject: line _is_ the first line of
> the commit log message.

I like to see commit logs that are more than just one line.

-- 
Timur Tabi
Linux kernel developer at Freescale

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Jon Loeliger]

Timur Tabi wrote:
> Jon Loeliger wrote:
> 
>> The mail Subject: line _is_ the first line of
>> the commit log message.
> 
> I like to see commit logs that are more than just one line.
> 

I don't like them when it isn't necessary.

Deal with it.

jdl

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Stefan Roese]

On Wednesday 14 November 2007, Timur Tabi wrote:
> Jon Loeliger wrote:
> > The mail Subject: line _is_ the first line of
> > the commit log message.
>
> I like to see commit logs that are more than just one line.

I like this too. But in some cases, one line is really enough. And this is the 
case here too.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Timur Tabi]

Timur Tabi wrote:

>>  #define CONFIG_RTL8139
>>  #define CONFIG_SK98
>>  #define CONFIG_EEPRO100
>>  #define CONFIG_TULIP
> 
> Shouldn't we undefine these macros?  With the on-board ULI working now, we don't 
> need these other NICs.

Obviously, I was only talking about the first three.  We still need to define 
CONFIG_TULIP.


-- 
Timur Tabi
Linux kernel developer at Freescale

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Zang Roy-r61911]

On Thu, 2007-11-15 at 00:40, Tabi Timur wrote:
> Timur Tabi wrote:
> 
> >>  #define CONFIG_RTL8139
> >>  #define CONFIG_SK98
> >>  #define CONFIG_EEPRO100
> >>  #define CONFIG_TULIP
> > 
> > Shouldn't we undefine these macros?  With the on-board ULI working
> now, we don't 
> > need these other NICs.
> 
> Obviously, I was only talking about the first three.  We still need to
> define 
> CONFIG_TULIP.
Change CONFIG_TULIP to CONFIG_ULI526X.
I intend to keep RTL8139 and Intel EEPR100. They work on the board and
can provide extra choices except the on board Ethernet port. 
I am not sure whether SK98 work. If it can not work, we can undef it.
Any idea?
Roy

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Timur Tabi]

Zang Roy-r61911 wrote:

> I intend to keep RTL8139 and Intel EEPR100. They work on the board and
> can provide extra choices except the on board Ethernet port. 

Well, the board config files should match what's on the board.  We don't ship 
the board with an RTL or Intel NIC, therefore the config file should not enable 
them.  With your logic, we should just enable ALL of the NICs that work.

If a customer inserts an RTL or Intel NIC, he can add those lines if he wants. 
Otherwise, all you're doing is bloating the binary.

-- 
Timur Tabi
Linux kernel developer at Freescale

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Scott Wood]

On Thu, Nov 15, 2007 at 08:03:15AM -0600, Timur Tabi wrote:
> Zang Roy-r61911 wrote:
> 
> > I intend to keep RTL8139 and Intel EEPR100. They work on the board and
> > can provide extra choices except the on board Ethernet port. 

Is there any reason one wouldn't want to use the on-board ethernet port?

> Well, the board config files should match what's on the board.  We don't
> ship the board with an RTL or Intel NIC, therefore the config file should
> not enable them.  With your logic, we should just enable ALL of the NICs
> that work.
> 
> If a customer inserts an RTL or Intel NIC, he can add those lines if he
> wants.  Otherwise, all you're doing is bloating the binary.

Hmm, weren't you scrounging around for a certain kind of PCI NIC that
your 8610 board's u-boot image supported not too long ago?

Wouldn't it have been nice if they built in support for a few of
the most common ones? :-)

-Scott

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Timur Tabi]

Scott Wood wrote:
> On Thu, Nov 15, 2007 at 08:03:15AM -0600, Timur Tabi wrote:
>> Zang Roy-r61911 wrote:
>>
>>> I intend to keep RTL8139 and Intel EEPR100. They work on the board and
>>> can provide extra choices except the on board Ethernet port. 
> 
> Is there any reason one wouldn't want to use the on-board ethernet port?

Not with this patch.  The only reason to enable all those other boards is 
because the on-board ethernet port *didn't* work, so everyone had to some some 
PCI NIC.

> Hmm, weren't you scrounging around for a certain kind of PCI NIC that
> your 8610 board's u-boot image supported not too long ago?

Yes.  That's because the on-board ethernet was not supported.

> Wouldn't it have been nice if they built in support for a few of
> the most common ones? :-)

And they did.  But now, it's no longer necessary.

-- 
Timur Tabi
Linux kernel developer at Freescale

[U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config

[Zang Roy-r61911]

On Fri, 2007-11-16 at 02:05, Tabi Timur wrote:
> Scott Wood wrote:
> > On Thu, Nov 15, 2007 at 08:03:15AM -0600, Timur Tabi wrote:
> >> Zang Roy-r61911 wrote:
> >>
> >>> I intend to keep RTL8139 and Intel EEPR100. They work on the board
> and
> >>> can provide extra choices except the on board Ethernet port. 
> > 
> > Is there any reason one wouldn't want to use the on-board ethernet
> port?
> 
> Not with this patch.  The only reason to enable all those other boards
> is 
> because the on-board ethernet port *didn't* work, so everyone had to
> some some 
> PCI NIC.
> 
That is also my opinion.
Roy