public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Final call: last minute fixes for 1.3.0 release ?
Date: Mon, 19 Nov 2007 11:14:16 +0900	[thread overview]
Message-ID: <4740F178.6000700@necel.com> (raw)
In-Reply-To: <20071118165023.GB4286@game.jcrosoft.org>

Jean-Christophe PLAGNIOL-VILLARD wrote:
>> * MIPS looks mostly OK, too, except here:
>>
>> 	gth2 board:
>>
>> 	lowlevel_init.S: Assembler messages:
>> 	lowlevel_init.S:413: Warning: Pretending global symbol used as branch target is local.
>>
> If I'm not wrong Shinya send a patch a bout it.

Hmm. I haven't ever seen such an warning with gcc 4.2.1 / bintuils 2.18.
Anyway patch is attached. Hope this helps.

---

[MIPS] board/gth2/lowlevel_init.S: Fix a build warning

From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>

lowlevel_init.S: Assembler messages:
lowlevel_init.S:413: Warning: Pretending global symbol used as branch target is local.

Looking at codes, the `memtest' and `clearmem' are intentional mixed use of
`global symbols' and `label' for debugging purpose. To make it builds, just
disable global-symbols-use for now.  As a result `memtest' still remains as
unused, but leave it be...

Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
---

 board/gth2/lowlevel_init.S |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/board/gth2/lowlevel_init.S b/board/gth2/lowlevel_init.S
index 983ff70..eea378a 100644
--- a/board/gth2/lowlevel_init.S
+++ b/board/gth2/lowlevel_init.S
@@ -413,7 +413,9 @@ noCacheJump:
 	j clearmem
 	nop
 
+#if 0
 	.globl	memtest
+#endif
 memtest:
 	/* Fill memory with address */
 	li	t0, 0x80000000
@@ -434,7 +436,9 @@ mt1:	lw	t2, 0(t0)
 	bne	t1, zero, mt1
 	nop
 	nop
+#if 0
 	.globl	clearmem
+#endif
 clearmem:
 		/* Clear memory */
 	li	t0, 0x80000000

  parent reply	other threads:[~2007-11-19  2:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-18 19:22 [U-Boot-Users] Final call: last minute fixes for 1.3.0 release ? Wolfgang Denk
2007-11-18 16:50 ` Jean-Christophe PLAGNIOL-VILLARD
2007-11-18 17:36   ` [U-Boot-Users] [PATCH 0/1] Fix usb_ohci.c missing in cpu/arm920t/s3c24x0/Makefile and usb_ohci.c Jean-Christophe PLAGNIOL-VILLARD
2007-11-18 17:36     ` [U-Boot-Users] [PATCH 1/1] Fix warning differ in signedness in cpu/pxa/i2c.c Jean-Christophe PLAGNIOL-VILLARD
2007-11-18 20:43       ` Wolfgang Denk
2007-11-18 20:50     ` [U-Boot-Users] [PATCH 0/1] Fix usb_ohci.c missing in cpu/arm920t/s3c24x0/Makefile and usb_ohci.c Wolfgang Denk
2007-11-19  2:14   ` Shinya Kuribayashi [this message]
2007-11-19 11:12     ` [U-Boot-Users] Final call: last minute fixes for 1.3.0 release ? Clemens Koller
2007-11-19 13:16       ` Wolfgang Denk
2007-11-19 20:49     ` Wolfgang Denk
2007-11-18 20:49 ` [U-Boot-Users] [PATCH] Fix AT91_USB_HOST_BASE undeclared for mp2usb Jean-Christophe PLAGNIOL-VILLARD
2007-11-18 23:54   ` Wolfgang Denk
2007-11-19 15:02 ` [U-Boot-Users] [PATCH]Move CONFIG_QE out of CONFIG_PCI wrap for MPC8568MDS Haiying Wang
2007-11-19 20:54   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4740F178.6000700@necel.com \
    --to=shinya.kuribayashi@necel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox