[U-Boot-Users] RFC: Makefile style question with testing?

[U-Boot-Users] RFC: Makefile style question with testing?

[Kumar Gala]

With Grant's work in testing I was wondering of the two options I have
below which is preferred:

option 1: duplicating CONFIG_OF_LIBFDT to maintain one line per source
file
option 2: put files that use same CONFIG_ on the same line

- k

diff --git a/common/Makefile b/common/Makefile
index ace8cc7..cf980bd 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -105,7 +105,7 @@ COBJS-y += env_onenand.o
 COBJS-y += env_nvram.o
 COBJS-y += env_nowhere.o
 COBJS-y += exports.o
-COBJS-y += fdt_support.o
+COBJS-$(CONFIG_OF_LIBFDT) += fdt_support.o
 COBJS-y += flash.o
 COBJS-y += fpga.o
 COBJS-y += ft_build.o

--- or ---

diff --git a/common/Makefile b/common/Makefile
index ace8cc7..7be89a4 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -55,7 +55,7 @@ COBJS-$(CONFIG_CMD_ELF) += cmd_elf.o
 COBJS-$(CONFIG_CMD_EXT2) += cmd_ext2.o
 COBJS-$(CONFIG_CMD_FAT) += cmd_fat.o
 COBJS-y += cmd_fdc.o
-COBJS-$(CONFIG_OF_LIBFDT) += cmd_fdt.o
+COBJS-$(CONFIG_OF_LIBFDT) += cmd_fdt.o fdt_support.o
 COBJS-$(CONFIG_CMD_FDOS) += cmd_fdos.o
 COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o
 ifdef CONFIG_FPGA
@@ -105,7 +105,6 @@ COBJS-y += env_onenand.o
 COBJS-y += env_nvram.o
 COBJS-y += env_nowhere.o
 COBJS-y += exports.o
-COBJS-y += fdt_support.o
 COBJS-y += flash.o
 COBJS-y += fpga.o
 COBJS-y += ft_build.o

[U-Boot-Users] RFC: Makefile style question with testing?

[Grant Likely]

On 11/26/07, Kumar Gala <galak@kernel.crashing.org> wrote:
> With Grant's work in testing I was wondering of the two options I have
> below which is preferred:
>
> option 1: duplicating CONFIG_OF_LIBFDT to maintain one line per source
> file
> option 2: put files that use same CONFIG_ on the same line

option 2 happens to be my preference as long as the lines don't get
too long or unreadable; but I don't think it's a big deal either way.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195

[U-Boot-Users] RFC: Makefile style question with testing?

[Jerry Van Baren]

Grant Likely wrote:
> On 11/26/07, Kumar Gala <galak@kernel.crashing.org> wrote:
>> With Grant's work in testing I was wondering of the two options I have
>> below which is preferred:
>>
>> option 1: duplicating CONFIG_OF_LIBFDT to maintain one line per source
>> file
>> option 2: put files that use same CONFIG_ on the same line
> 
> option 2 happens to be my preference as long as the lines don't get
> too long or unreadable; but I don't think it's a big deal either way.
> 
> g.

Ditto.

gvb