[U-Boot-Users] [PATCH]: tools: fix fw_printenv tool to compile again

[Ben Warren <bwarren@qstreams.com>]

Markus Klotzb?cher wrote:
> Dear Ben, Wolfang,
>
> Wolfgang Denk <wd@denx.de> writes:
>
>   
>> In message <87r6idhs49.fsf@denx.de> you wrote:
>>
>> Hm... this is only the "correct mtd header" if you are building for
>> somewhat recent versions of the Linux kernel - if you want to support
>> his on older versions (using older versions of MTD code) this will
>> break.
>>     
>
> I see.
>
>   
>> I suggest we optionally provide a build option to allow  to  use  the
>> old  include files for systems that still need it (as a separate make
>> target, for example).
>>     
>
> How about the following:
>
> This patch updates the fw_printenv/fw_setenv userspace tool to include
> the correct MTD header in order to compile against current kernel
> headers. Backward compatibility is preserved by introducing an option
> MTD_VERSION which can be set to "old" for compilation using the old MTD
> headers. Along with this a number of warnings are fixed.
>   
Sounds good to me.  It'd be cooler if make could detect the 
presence/absence of <linux/mtd-user.h>, but I'm not enough of a build 
system whiz to know how to do that.

A couple of additional requests:

1.  Can you also please add the other part of my patch that 
creates/destroys the 'fw_setenv' symbolic link?  It's a bit annoying 
that the documentation mentions the 'fw_setenv' utility, but it doesn't 
really exist without a bit of help.

2.  Please include changes to the relevant documentation (README + wiki) 
so that people know to when and how to set MTD_VERSION.  This may 
prevent a few 'RTFM' e-mails.

regards,
Ben