From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Tue, 27 Nov 2007 10:34:36 -0500 Subject: [U-Boot-Users] [PATCH]: tools: fix fw_printenv tool to compile again In-Reply-To: <871wacjb3r.fsf@denx.de> References: <20071126221946.48B6D247C1@gemini.denx.de> <871wacjb3r.fsf@denx.de> Message-ID: <474C390C.8060007@qstreams.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Markus Klotzb?cher wrote: > Dear Ben, Wolfang, > > Wolfgang Denk writes: > > >> In message <87r6idhs49.fsf@denx.de> you wrote: >> >> Hm... this is only the "correct mtd header" if you are building for >> somewhat recent versions of the Linux kernel - if you want to support >> his on older versions (using older versions of MTD code) this will >> break. >> > > I see. > > >> I suggest we optionally provide a build option to allow to use the >> old include files for systems that still need it (as a separate make >> target, for example). >> > > How about the following: > > This patch updates the fw_printenv/fw_setenv userspace tool to include > the correct MTD header in order to compile against current kernel > headers. Backward compatibility is preserved by introducing an option > MTD_VERSION which can be set to "old" for compilation using the old MTD > headers. Along with this a number of warnings are fixed. > Sounds good to me. It'd be cooler if make could detect the presence/absence of , but I'm not enough of a build system whiz to know how to do that. A couple of additional requests: 1. Can you also please add the other part of my patch that creates/destroys the 'fw_setenv' symbolic link? It's a bit annoying that the documentation mentions the 'fw_setenv' utility, but it doesn't really exist without a bit of help. 2. Please include changes to the relevant documentation (README + wiki) so that people know to when and how to set MTD_VERSION. This may prevent a few 'RTFM' e-mails. regards, Ben