From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Tue, 27 Nov 2007 15:46:33 -0500 Subject: [U-Boot-Users] [PATCH]: tools: fix fw_printenv tool to compile again In-Reply-To: <87sl2rfmxy.fsf@denx.de> References: <20071126221946.48B6D247C1@gemini.denx.de> <871wacjb3r.fsf@denx.de> <474C390C.8060007@qstreams.com> <87sl2rfmxy.fsf@denx.de> Message-ID: <474C8229.4080608@qstreams.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Markus Klotzb?cher wrote: > Hi Ben, > > Ben Warren writes: > > >> Markus Klotzb?cher wrote: >> >>> How about the following: >>> >>> This patch updates the fw_printenv/fw_setenv userspace tool to include >>> the correct MTD header in order to compile against current kernel >>> headers. Backward compatibility is preserved by introducing an option >>> MTD_VERSION which can be set to "old" for compilation using the old MTD >>> headers. Along with this a number of warnings are fixed. >>> >>> >> Sounds good to me. It'd be cooler if make could detect the >> presence/absence of , but I'm not enough of a build >> system whiz to know how to do that. >> > > I'm afraid nor am I. Suggestions welcome. > > >> A couple of additional requests: >> >> 1. Can you also please add the other part of my patch that >> creates/destroys the 'fw_setenv' symbolic link? It's a bit annoying >> that the documentation mentions the 'fw_setenv' utility, but it >> doesn't really exist without a bit of help. >> > > Agreed that this confusing, but does a symbolic link really help? > Wouldn't it be better to simply describe the rationale in the > documentation instead? > > I like the symbolic link, because when done you end up with an executable called 'fw_setenv' and move it to the file system with 'cp -a'. I don't care too much though, as long as it's documented somewhere where people will see it. Personally, I went through a "where the eff is the fw_setenv utility that's mentioned in the documentation" and eventually looked in the source code and noticed that it uses argv[0]... Sparing others this grief would be nice. >> 2. Please include changes to the relevant documentation (README + >> wiki) so that people know to when and how to set MTD_VERSION. This >> may prevent a few 'RTFM' e-mails. >> > > The patch I posted updates the README in tools/env/ and I'll update the > wiki as soon as the patch is accepted. I wonder though, if the > env/tools/README shouldn't be move into the main README. It's rather > hidden where it is right now. > > Yeah, either there or in /doc. It's badly hidden now. > Viele Gr??e / Best regards > > Markus Klotzb?cher > > cheers, B-)