From: Ben Warren <bwarren@qstreams.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] NET: Proper return code handling in eth_init() function in file eth.c
Date: Wed, 28 Nov 2007 10:39:08 -0500 [thread overview]
Message-ID: <474D8B9C.20205@qstreams.com> (raw)
In-Reply-To: <8FCC6A94CA3DF74CB89E1044DBFB0BF806BE1C@NOIDA-MAIL2.bbnet.ad>
Upakul,
Upakul Barkakaty wrote:
> NET: Proper return code handling in eth_init() function in file eth.c
>
> This patch modifies the return code handling in the eth_init() function,
> to be compatible with the handling of the return codes in the other
> network stack files. It now returns a 0 on Success and -1 on error.
>
> Signed-off-by: Upakul Barkakaty <upakul.barkakaty@conexant.com>
>
> Conexant E-mail Firewall (Conexant.Com) made the following annotations
> ---------------------------------------------------------------------
> ********************** Legal Disclaimer ****************************
>
> "This email may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictly prohibited. If you have received the message in error, please advise the sender by reply email and delete the message. Thank you."
>
> **********************************************************************
>
> ---------------------------------------------------------------------
>
>
This looks good, but I'm going to ask you to re-send with the following
modifications:
1. Paste the patch in-line with your message. This makes it much easier
for me to apply. If you're using Thunderbird or Evolution, select
'Preformat' as the text style to avoid line wrapping and other
formatting badness.
2. Send it from an e-mail service that doesn't tack on the legal
disclaimer crap.
regards,
Ben
next prev parent reply other threads:[~2007-11-28 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 5:18 [U-Boot-Users] [PATCH] NET: Proper return code handling in eth_init() function in file eth.c Upakul Barkakaty
2007-11-28 15:39 ` Ben Warren [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-29 6:04 Upakul Barkakaty
2007-11-29 6:24 ` Stefan Roese
2007-11-29 6:46 ` Upakul Barkakaty
2008-01-08 14:26 ` Stefan Roese
2008-01-08 14:35 ` Upakul Barkakaty
2008-01-08 14:50 ` Upakul Barkakaty
2008-01-08 14:56 ` Ben Warren
2008-01-08 17:26 ` Stefan Roese
2008-01-08 21:10 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474D8B9C.20205@qstreams.com \
--to=bwarren@qstreams.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox