From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Fri, 30 Nov 2007 16:34:10 -0600
Subject: [U-Boot-Users] qe: add ability to upload QE firmware
In-Reply-To: <93E5AFB9-9143-4B73-B357-C30BB5C840D7@kernel.crashing.org>
References: <11964576432250-git-send-email-timur@freescale.com>
	<93E5AFB9-9143-4B73-B357-C30BB5C840D7@kernel.crashing.org>
Message-ID: <47508FE2.5020903@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Kumar Gala wrote:

>> +U_BOOT_CMD(
>> +    qe, 4, 0, qe_cmd,
>> +    "qe      - QUICC Engine commands\n",
>> +    "fw <addr> [<length>] - Upload firmware at address <addr>,\n"
> 
> I'm at a loss, why have length at all?  You seem to always take it from 
> firmware->header.length.

It's optional.  If you specify the length, it will validate that against 
header.length.  That's so that you can do this:

tftp $loadaddr $firmware
qe fw $loadaddr $filesize

If the length doesn't match, then it doesn't bother trying to parse the rest of 
the image.

The Linux version of this code does the same thing, but it's probably more 
useful since drivers will use request_firmware() which returns a length.

Granted, the CRC check is more bullet-proof.

> Also can we be more explicit in the help with 'Upload firmware'.. to 
> 'Upload microcode firmware to QE' or something like that.

Sure.  New patch coming.

-- 
Timur Tabi
Linux kernel developer at Freescale