From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC575C433F5 for ; Wed, 1 Dec 2021 19:11:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6674A830B3; Wed, 1 Dec 2021 20:11:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NPc7T540"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8C80283092; Wed, 1 Dec 2021 20:11:21 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6F7EB830B3 for ; Wed, 1 Dec 2021 20:11:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf32.google.com with SMTP id p3so15461103qvj.9 for ; Wed, 01 Dec 2021 11:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+OH/ld0QO/F1K8R4MlaYu3JRpX9DKflRmdRsqBh1Y7s=; b=NPc7T540cBkQzwD86cpbL9bKL7QY7DYaXZhEukBWSxg2hf51fniqa1KUC+RldCFELO J4qQYVPJZj3DqyrxbrqpbY/rGKwikC8twcDK6GwaDcauF5yzWZ8gnlvTY/VC5dS8ydjZ Ri+PgkMt/CJ4/d4Zb69kx/PbiHOFRuNu2ZRVPlwV44m85fLnTLvrlVa5JmyAg1XeZlGv Q2CcRyT7lu4DIsFXNHGdlc3n/lKIUPuLVOwUcbADjOHIFXb5k7C1SZW+jus3Lcx+mqi9 0eiC4AO9VEa+WOPUMpXFS8j7RTV4JEn91wzwuSR7xwQNUEOBeT2xFuT7VE1tY+rZ5Vpd 9bzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+OH/ld0QO/F1K8R4MlaYu3JRpX9DKflRmdRsqBh1Y7s=; b=1rQA6z6yPtIyd80bQBYxzGf1RGiM0X7HCYWr8gfWM0zrUk4MX3hwbTxtKz6uhzQNFA JKPHbHNYnkaQ+hzAz7MOwjBhIJbtAxoNHo39UXJ/P1rpY2rkJPGSO3kUddUQjVutMDuQ zVnEo6lorlFKBIQAxWJ1TMM3TxdZoyJYWJpNb54gS0jVg0CneMl9dBa36V+zDzUKkVAb cgYTg/i0HKHcz+RJKeGQW9K1x9cYHFONKPLVPHvikBIJ8RGWnpW3YNGJ99z/sZTOMvhV v8sBGjDuyTXw86m1u/fBuwJ/dK6X5wzGU/EEjtNdKGnik5SvbqneTS0gPL50ND54IHL0 eXhg== X-Gm-Message-State: AOAM533NmWdG98Rl6Ba3ASOVwrAC1pQG7S2HEerfDBNJ569nTkAVOFfk LPJF6+lJoJyGzX5AmgwaovA= X-Google-Smtp-Source: ABdhPJyylaX5QIt6OIfOnY0jhxTQWLoxjFDYTwGGQ/SF5yeFgUfnb6l9p3cQrr9XeHU/tsGbr4TXTQ== X-Received: by 2002:ad4:54f2:: with SMTP id k18mr8388834qvx.63.1638385876210; Wed, 01 Dec 2021 11:11:16 -0800 (PST) Received: from [192.168.1.201] (pool-108-18-207-184.washdc.fios.verizon.net. [108.18.207.184]) by smtp.googlemail.com with ESMTPSA id g14sm310735qko.55.2021.12.01.11.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Dec 2021 11:11:15 -0800 (PST) From: Sean Anderson Subject: Re: [PATCH V4] clk: clk_versaclock: Add support for versaclock driver To: Adam Ford , u-boot@lists.denx.de Cc: lukma@denx.de, sean.anderson@seco.com, luca@lucaceresoli.net, charles.stevens@logicpd.com, aford@beaconembedded.com References: <20210604172606.52453-1-aford173@gmail.com> Message-ID: <4760ab9d-d963-19e5-8472-1bd977d011cd@gmail.com> Date: Wed, 1 Dec 2021 14:11:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210604172606.52453-1-aford173@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Adam, On 6/4/21 1:26 PM, Adam Ford wrote: > +/* > + * The device references to the Versaclock point to the head, so xlate needs to > + * redirect it to clk_out[idx] > + */ > +static int vc5_clk_out_xlate(struct clk *hw, struct ofnode_phandle_args *args) > +{ > + unsigned int idx = args->args[0]; > + > + if (args->args_count != 1) { > + debug("Invaild args_count: %d\n", args->args_count); > + return -EINVAL; > + } > + > + hw->id = idx; > + > + return 0; > +} Can you explain a bit more why this is needed? I looked it over a few times, and I'm not sure what it does differently from clk_of_xlate_default. --Sean