From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Thu, 13 Dec 2007 13:49:23 -0500
Subject: [U-Boot-Users] Can U-boot Autodetect arch/ppcversusarch/powerpc
 from info in the uImage?
In-Reply-To: <20071209150038.D560B247F5@gemini.denx.de>
References: <20071209150038.D560B247F5@gemini.denx.de>
Message-ID: <47617EB3.5030809@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> In message <1197205927.937.51.camel@gentoo-jocke.transmode.se> you wrote:
>> Made a new patch with Jerrys comments addressed. Also renamed
>> DEFAULT_OF_TREE to CFG_OF_TREE. OK?
> 
> I still object against this modification.
> 
>> +#ifdef CFG_OF_TREE
>> +	char	*of_flat_tree = CFG_OF_TREE;
>> +#else
>>  	char	*of_flat_tree = NULL;
>> +#endif
>>  	ulong	of_data = 0;
>>  #endif
> 
> I hereby NAK this patch for 3 reasons:
> 
> 1) The patch does not solve a problem. Instead of hardwiring the
>    address, you can just pass it as argument to the bootm command
>    which seems more straightforward to me
> 
> 2) The patch causes confusion. Documented behaviour is that "bootm"
>    with one or two arguments (kernel address, or kernel plus ramdisk
>    addresses) will boot a non-OF enabled kernel. With this patch,
>    "bootm" will behave different on systems where the CFG_OF_TREE has
>    been selected - which is usually not known to and cannot be
>    checked by the end user, thus causing confusion.
> 
> 3) With the patch applied and CFG_OF_TREE defined, there is no way to
>    boot a non-OF kernel, thus breaking backward compatibility.
> 
> Best regards,
> 
> Wolfgang Denk

FWIIW, #2 and #3 are serious problems that I had not considered when I 
supported Jocke's proposed patch.  Sorry, Jocke, but I have to side with 
Wolfgang in light of those arguments.

Best regards,
gvb