[U-Boot-Users] Problems Building u-boot-1.3.1

[U-Boot-Users] Problems Building u-boot-1.3.1

[raptorbrino at aim.com]

Hi All,

I'm having a problem building u-boot-1.3.1.  It complains when using the
host compiler to compile sha1.c because it doesn't know what the data 
type
__u64 is.  This datatype is defined in u-boot/include/asm/types.h.  
However,
I'm using cygwin, and it has the file /usr/include/asm/types.h.  The 
types.h
file in cygwin does not define __u64.  Because the compile uses the flag
-idirafter, the cygwin types.h is used in the include, hence an unkown
symbol compile error.  I fixed this problem in my local build by adding 
the
flag -ansi to CPPFLAGS in tools/makefile.  Is that appropriate or would 
you
recommend fixing it another way??

Thanks,
Brian
________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! - 
http://webmail.aim.com

[U-Boot-Users] Problems Building u-boot-1.3.1

[Markus Klotzbücher]

raptorbrino at aim.com writes:

> I'm having a problem building u-boot-1.3.1.  It complains when using the
> host compiler to compile sha1.c because it doesn't know what the data 
> type
> __u64 is.  This datatype is defined in u-boot/include/asm/types.h.  
> However,
> I'm using cygwin, and it has the file /usr/include/asm/types.h.  The 
> types.h
> file in cygwin does not define __u64.  Because the compile uses the flag
> -idirafter, the cygwin types.h is used in the include, hence an unkown
> symbol compile error.  I fixed this problem in my local build by adding 
> the
> flag -ansi to CPPFLAGS in tools/makefile.  Is that appropriate or would 
> you
> recommend fixing it another way??

I would recommend fixing it by using a nice Linux system instead of
Win$, but thats just me...

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

[U-Boot-Users] Problems Building u-boot-1.3.1

[raptorbrino at aim.com]

I guess a better question is whether u-boot should support
builds on cygwin without modification.  If the answer is
"doesn't matter," your answer suffices.  If the answer is
yes, something must be modified.  My fix was to add the
-ansi switch to the build flags, however, there's probably
a less invasive way than requiring the compiler to only use
ansi compliant features.

raptorbrino at aim.com writes:

> I'm having a problem building u-boot-1.3.1.  It complains when using 
the
> host compiler to compile sha1.c because it doesn't know what the data
> type
> __u64 is.  This datatype is defined in u-boot/include/asm/types.h.
> However,
> I'm using cygwin, and it has the file /usr/include/asm/types.h.  The
> types.h
> file in cygwin does not define __u64.  Because the compile uses the 
flag
> -idirafter, the cygwin types.h is used in the include, hence an unkown
> symbol compile error.  I fixed this problem in my local build by 
adding
> the
> flag -ansi to CPPFLAGS in tools/makefile.  Is that appropriate or 
would
> you
> recommend fixing it another way??

I would recommend fixing it by using a nice Linux system instead of
Win$, but thats just me...

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de






________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! - 
http://webmail.aim.com

[U-Boot-Users] Problems Building u-boot-1.3.1

[Wolfgang Denk]

A: Because it messes up the order in which people normally read text.

Q: Why is top-posting such a bad thing?

A: Top-posting.

Q: What is the most annoying thing in e-mail?

Please read http://www.netmeister.org/news/learn2quote.html

In message <8CA0BD0484CF342-A30-CFA@WEBMAIL-DF07.sysops.aol.com> you wrote:
> I guess a better question is whether u-boot should support
> builds on cygwin without modification.  If the answer is

Yes, but only if it doesn't hurt others.

> "doesn't matter," your answer suffices.  If the answer is
> yes, something must be modified.  My fix was to add the
> -ansi switch to the build flags, however, there's probably
> a less invasive way than requiring the compiler to only use
> ansi compliant features.

Maybe cygwin povides another header file for the definition of __u64?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When it is incorrect, it is, at least *authoritatively* incorrect.
                                    - Hitchiker's Guide To The Galaxy

[U-Boot-Users] Problems Building u-boot-1.3.1

[Ben Warren]

raptorbrino at aim.com wrote:
> I guess a better question is whether u-boot should support
> builds on cygwin without modification.  If the answer is
> "doesn't matter," your answer suffices.  If the answer is
> yes, something must be modified.  My fix was to add the
> -ansi switch to the build flags, however, there's probably
> a less invasive way than requiring the compiler to only use
> ansi compliant features.
>
> raptorbrino at aim.com writes:
>
>   
>> I'm having a problem building u-boot-1.3.1.  It complains when using 
>>     
> the
>   
>> host compiler to compile sha1.c because it doesn't know what the data
>> type
>> __u64 is.  This datatype is defined in u-boot/include/asm/types.h.
>> However,
>> I'm using cygwin, and it has the file /usr/include/asm/types.h.  The
>> types.h
>> file in cygwin does not define __u64.  Because the compile uses the 
>>     
> flag
>   
>> -idirafter, the cygwin types.h is used in the include, hence an unkown
>> symbol compile error.  I fixed this problem in my local build by 
>>     
> adding
>   
>> the
>> flag -ansi to CPPFLAGS in tools/makefile.  Is that appropriate or 
>>     
> would
>   
>> you
>> recommend fixing it another way??
>>     
>
> I would recommend fixing it by using a nice Linux system instead of
> Win$, but thats just me...
>
>   
Yeah, Linux host would be best. Have you tried:

export C_INCLUDE_PATH=$C_INCLUDE_PATH:<u-boot src path>/include ?

Dunno if this will help or not. I think gcc makes C_INCLUDE_PATH the 
highest priority search path, but could very well be wrong.

regards,
Ben

[U-Boot-Users] Problems Building u-boot-1.3.1

[raptorbrino at aim.com]

After a gentle slap in the face by Markus about my choice of
OS and a thorough beat down by Wolfgang about my inexperienced
message posting style I'm back for more punishment!  I tremble
with every character I type, but to all Cygiwn users out there,
I propose the following fix for the cygwin build problem.  This
should allow Linux users to be happy and allow cygwin users to
build without error, albeit penalize them for using the
inadequate Windows OS!  Damn I hope I did this right.

diff -Naur old/tools/Makefile new/tools/Makefile
--- old/tools/Makefile  2007-12-06 01:21:19.000000000 -0800
+++ new/tools/Makefile  2007-12-13 12:22:15.796875000 -0800
@@ -97,6 +97,7 @@
 #
 ifeq ($(HOSTOS),cygwin)
 SFX = .exe
+HOST_CFLAGS += -ansi
 else
 SFX =
 endif






________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! - 
http://webmail.aim.com

[U-Boot-Users] Problems Building u-boot-1.3.1

[Wolfgang Denk]

In message <8CA0BE244FB6554-908-417D@webmail-db12.sysops.aol.com> you wrote:
> After a gentle slap in the face by Markus about my choice of
> OS and a thorough beat down by Wolfgang about my inexperienced
> message posting style I'm back for more punishment!  I tremble
> with every character I type, but to all Cygiwn users out there,
> I propose the following fix for the cygwin build problem.  This
> should allow Linux users to be happy and allow cygwin users to
> build without error, albeit penalize them for using the
> inadequate Windows OS!  Damn I hope I did this right.

...if you could please add your Signed-off-by: line, too?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How can you tell when sour cream goes bad?

[U-Boot-Users] Problems Building u-boot-1.3.1

[raptorbrino at aim.com]

Wolfgang wrote:
> ...if you could please add your Signed-off-by: line, too?

Slowly learning ...

Signed-off-by: Brian Miller <raptorbrino@netscape.net>





________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! - 
http://webmail.aim.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: application/octet-stream
Size: 272 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20071213/0ba34af1/attachment.obj 

[U-Boot-Users] Problems Building u-boot-1.3.1

[raptorbrino at aim.com]

Sorry guys, first time posting a patch and I believe the formatting
of my last mail was all wrong.  Here's a better attempt at it.

This patch allows u-boot to build without error in a cygwin
environment.  Cygwin does not define __u64 in it's
include/asm/types.h file.  The -idirafter flag in the u-boot
build causes the inclusion of the cygwin types.h file as opposed
to u-bot/include/asm/types.h file which does define __u64.
Subsequently, sha1.c compile fails due to unknown symbol.

Signed-off-by: Brian Miller <raptorbrino@netscape.net>

diff -purN old/tools/Makefile new/tools/Makefile
--- old/tools/Makefile  2007-12-06 01:21:19.000000000 -0800
+++ new/tools/Makefile  2007-12-13 12:22:15.796875000 -0800
@@ -97,6 +97,7 @@ endif
 #
 ifeq ($(HOSTOS),cygwin)
 SFX = .exe
+HOST_CFLAGS += -ansi
 else
 SFX =
 endif
________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! - 
http://webmail.aim.com

[U-Boot-Users] Problems Building u-boot-1.3.1

[Jon Loeliger]

Hi Brian,

You are getting closer! :-)  For perfection, you need
to adjust a few things.  First, make your mail Subject: line
be a concise one-line summary of your patch prefixed with
a "[PATCH]" so we can spot it, and then launch into the
rest of your log message.

Secondly, non-log commentary like this:

On Thu, 2007-12-13 at 20:23, raptorbrino at aim.com wrote:
> Sorry guys, first time posting a patch and I believe the formatting
> of my last mail was all wrong.  Here's a better attempt at it.

belongs after a "---" line, but before your diff content.

> This patch allows u-boot to build without error in a cygwin
> environment.  Cygwin does not define __u64 in it's
> include/asm/types.h file.  The -idirafter flag in the u-boot
> build causes the inclusion of the cygwin types.h file as opposed
> to u-bot/include/asm/types.h file which does define __u64.
> Subsequently, sha1.c compile fails due to unknown symbol.
> 
> Signed-off-by: Brian Miller <raptorbrino@netscape.net>

Right here!  Like this:

---

Additional commentary here....

and then your patch!

> diff -purN old/tools/Makefile new/tools/Makefile
> --- old/tools/Makefile  2007-12-06 01:21:19.000000000 -0800
> +++ new/tools/Makefile  2007-12-13 12:22:15.796875000 -0800
> @@ -97,6 +97,7 @@ endif
>  #
>  ifeq ($(HOSTOS),cygwin)
>  SFX = .exe
> +HOST_CFLAGS += -ansi
>  else
>  SFX =
>  endif

Keep up the good fight!

Good luck,
jdl

[U-Boot-Users] Problems Building u-boot-1.3.1

[Wolfgang Denk]

In message <8CA0C0F7296630A-FC4-25B8@WEBMAIL-MC01.sysops.aol.com> you wrote:
> Sorry guys, first time posting a patch and I believe the formatting
> of my last mail was all wrong.  Here's a better attempt at it.
> 
> This patch allows u-boot to build without error in a cygwin
> environment.  Cygwin does not define __u64 in it's
> include/asm/types.h file.  The -idirafter flag in the u-boot
> build causes the inclusion of the cygwin types.h file as opposed
> to u-bot/include/asm/types.h file which does define __u64.
> Subsequently, sha1.c compile fails due to unknown symbol.
> 
> Signed-off-by: Brian Miller <raptorbrino@netscape.net>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
KLB is an acronym for `Known Lazy Bastard', aka non-FAQ  reader,  aka
person  who  would  rather  make  someone  take their time to explain
something basic than look it up in a  FAQ.
         -- Tom Christiansen in <6aq547$mnr$2@csnews.cs.colorado.edu>