From: Bartlomiej Sieka <tur@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Can we drop I386 specific hack from do_bootm()?
Date: Wed, 19 Dec 2007 16:03:00 +0100 [thread overview]
Message-ID: <476932A4.5000002@semihalf.com> (raw)
Hello,
While working on adapting do_bootm() to new uImage format, I've came
across this I386-specific hack:
#ifdef __I386__ /* correct image format not implemented yet - fake it */
if (fake_header(hdr, (void*)addr, -1) != NULL) {
/* to compensate for the addition below */
addr -= sizeof(image_header_t);
/* turnof verify,
* fake_header() does not fake the data crc
*/
verify = 0;
} else
#endif /* __I386__ */
It looks like I386 targets provide the kernel as an zImage, instead of
an uImage, and this special case is needed to add a faked uImage header,
so that the rest of the booting code works without modification.
How about dropping this hack altogether? This would make the code
cleaner, but would require I386 targets (sc520_cdp, sc520_spunk) to use
kernels in uImage format.
What do people think? What is the opinion of the maintainer of the
affected platforms (Daniel Engstr?m, copied)?
Regards,
Bartlomiej
next reply other threads:[~2007-12-19 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 15:03 Bartlomiej Sieka [this message]
2007-12-27 15:07 ` [U-Boot-Users] Can we drop I386 specific hack from do_bootm()? Bartlomiej Sieka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476932A4.5000002@semihalf.com \
--to=tur@semihalf.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox