From mboxrd@z Thu Jan 1 00:00:00 1970 From: gvb.uboot Date: Thu, 27 Dec 2007 08:43:26 -0500 Subject: [U-Boot-Users] [PATCH] common/cmd_mii.c: Add sanity argc check In-Reply-To: <47734CA3.9020803@necel.com> References: <477348BA.5090201@necel.com> <47734CA3.9020803@necel.com> Message-ID: <4773ABFE.3060803@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Shinya Kuribayashi wrote: > Shinya Kuribayashi wrote: >> If type mii command without arguments, we suffer from uninitialized argv[] >> entries; for example we MIPS get stuck by TLB error. >> >> Signed-off-by: Shinya Kuribayashi >> --- >> >> common/cmd_mii.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/common/cmd_mii.c b/common/cmd_mii.c >> index b771322..b99bd06 100644 >> --- a/common/cmd_mii.c >> +++ b/common/cmd_mii.c >> @@ -438,6 +438,11 @@ int do_mii (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) >> int rcode = 0; >> char *devname; >> >> + if (argc < 2) { >> + printf("Usage:\n%s\n", cmdtp->usage); >> + return 1; >> + } >> + >> #if defined(CONFIG_8xx) || defined(CONFIG_MCF532x) >> mii_init (); >> #endif > > By the way, cmd_mii.c has _another_ do_mii() which is enabled for > CONFIG_TERSE_MII user. But it seems there is no CONFIG_TERSE_MII user. > I just wonder that do_mii() is in the transition to the newer version. > > thanks, > > Shinya Hi Shinya, Good find & fix on the argc bug. When I originally wrote the mii command 6(!) years ago, I wrote a verbose version that printed human readable decomposition of the flags, etc., and a terse one that didn't print as much stuff and thus had a smaller memory footprint. It sounds like the terse version has withered and died, apparently people are only using the verbose version (which is very understandable, I do myself). I propose that you remove what remains of the terse version as part of your cleanup patch. If anybody actually needs the terse version, speak up! Thanks, gvb