From: Larry Johnson <lrj@arlinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] CFG_EEPROM_PAGE_WRITE_ENABLE [Was: Re: [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor]
Date: Thu, 27 Dec 2007 12:16:42 -0500 [thread overview]
Message-ID: <4773DDFA.2040603@arlinx.com> (raw)
In-Reply-To: <200712271311.33933.sr@denx.de>
Stefan Roese wrote:
> Hi Larry,
>
> On Saturday 22 December 2007, Larry Johnson wrote:
>> This driver is based on the driver for the LM75.
>
> Patch seems to be line wrapped. Please fix and resubmit.
> Thanks.
>
> Best regards,
> Stefan
>
> =====================================================================
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
> =====================================================================
I noticed that the offending line was part of a check to ensure that the
symbol "CFG_EEPROM_PAGE_WRITE_ENABLE" is defined. However, I don't see
this switch being used anywhere in the code, although several other HWMON
drivers also check that it is defined. Does anyone know of a reason to
keep defining it?
Best regards,
Larry
prev parent reply other threads:[~2007-12-27 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 20:14 [U-Boot-Users] [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor Larry Johnson
2007-12-23 10:40 ` Jean-Christophe PLAGNIOL-VILLARD
2007-12-27 12:18 ` Stefan Roese
2007-12-27 17:56 ` Jean-Christophe PLAGNIOL-VILLARD
2007-12-27 12:11 ` Stefan Roese
2007-12-27 17:16 ` Larry Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4773DDFA.2040603@arlinx.com \
--to=lrj@arlinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox