From mboxrd@z Thu Jan  1 00:00:00 1970
From: Larry Johnson <lrj@arlinx.com>
Date: Thu, 27 Dec 2007 12:16:42 -0500
Subject: [U-Boot-Users] CFG_EEPROM_PAGE_WRITE_ENABLE [Was: Re: [PATCH 2/9]
 Add driver for National Semiconductor LM73 temperature sensor]
In-Reply-To: <200712271311.33933.sr@denx.de>
References: <476D7020.8080906@arlinx.com> <200712271311.33933.sr@denx.de>
Message-ID: <4773DDFA.2040603@arlinx.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Stefan Roese wrote:
> Hi Larry,
> 
> On Saturday 22 December 2007, Larry Johnson wrote:
>> This driver is based on the driver for the LM75.
> 
> Patch seems to be line wrapped. Please fix and resubmit.
> Thanks.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================

I noticed that the offending line was part of a check to ensure that the
symbol "CFG_EEPROM_PAGE_WRITE_ENABLE" is defined.  However, I don't see
this switch being used anywhere in the code, although several other HWMON
drivers also check that it is defined.  Does anyone know of a reason to
keep defining it?

Best regards,
Larry