From: Larry Johnson <lrj@arlinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor
Date: Fri, 28 Dec 2007 08:43:41 -0500 [thread overview]
Message-ID: <4774FD8D.50900@arlinx.com> (raw)
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:18 Thu 27 Dec , Stefan Roese wrote:
>> On Sunday 23 December 2007, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
>>>> index cebb2ba..32e3f44 100644
>>>> --- a/drivers/hwmon/Makefile
>>>> +++ b/drivers/hwmon/Makefile
>>>> @@ -34,6 +34,7 @@ COBJS-y += adm1021.o
>>>> COBJS-y += ds1621.o
>>>> COBJS-y += ds1722.o
>>>> COBJS-y += ds1775.o
>>>> +COBJS-y += lm73.o
>>>> COBJS-y += lm75.o
>>>> COBJS-y += lm81.o
>>> I will send soon (today or tomorow) the Makefile with conditional
>>> compilation please rebase your patch about drivers on it.
>> I would like to get those patches accepted and merged in this merge window. We
>> should not delay this by waiting on your conditional compilation rework
>> (which is good of course). So I suggest to get such patches merged right now
>> and fix possible problems with future additions later.
>
> I understand you view but il will great if the new driver could be use
> conditional Makefile.o
>
> Could you do this modification pls
>
> COBJS-$(CONFIG_DTT_LM73) += lm73.o
>
> instead of
>> +COBJS-y += lm73.o
>
> and remove if ifdef CONFIG_DTT_LM73 from the lm73.c
>
> Thanks by advance,
> J.
I have tested a patch to make this change and to remove the references
to "CFG_EEPROM_PAGE_WRITE_ENABLE". If there is no objection, I would
prefer to submit this patch after Stefan finishes adding the original
patch, rather than amend the original patch.
Best regards,
Larry
next reply other threads:[~2007-12-28 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 13:43 Larry Johnson [this message]
2007-12-28 15:42 ` [U-Boot-Users] [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor Stefan Roese
2007-12-28 16:23 ` Larry Johnson
[not found] ` <4775DC12.6020909@arlinx.com>
2007-12-29 8:33 ` Stefan Roese
-- strict thread matches above, loose matches on Subject: below --
2007-12-22 20:14 Larry Johnson
2007-12-23 10:40 ` Jean-Christophe PLAGNIOL-VILLARD
2007-12-27 12:18 ` Stefan Roese
2007-12-27 17:56 ` Jean-Christophe PLAGNIOL-VILLARD
2007-12-27 12:11 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4774FD8D.50900@arlinx.com \
--to=lrj@arlinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox