public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Larry Johnson <lrj@arlinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor
Date: Fri, 28 Dec 2007 11:23:44 -0500	[thread overview]
Message-ID: <47752310.4030003@arlinx.com> (raw)
In-Reply-To: <200712281642.54134.sr@denx.de>

Stefan Roese wrote:
> On Friday 28 December 2007, Larry Johnson wrote:
>>> I understand you view but il will great if the new driver could be use
>>> conditional Makefile.o
>>>
>>> Could you do this modification pls
>>>
>>> COBJS-$(CONFIG_DTT_LM73) += lm73.o
>>>
>>> instead of
>>>
>>>> +COBJS-y += lm73.o
>>> and remove if ifdef CONFIG_DTT_LM73 from the lm73.c
>>>
>>> Thanks by advance,
>>> J.
>> I have tested a patch to make this change and to remove the references
>> to "CFG_EEPROM_PAGE_WRITE_ENABLE".  If there is no objection, I would
>> prefer to submit this patch after Stefan finishes adding the original
>> patch, rather than amend the original patch.
> 
> Yes, I would like to do it this way too.
> 
> I'm waiting for some final patches from Matthias and will send the pull 
> request to Wolfgang after those are merged today or latest tomorrow.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================

BTW, my patches will have some interaction with what Matthias is doing.  In
particular, the addition and correction of Denali SDRAM definitions to
"ppc440.h" causes the compiler to warn of some preprocessor redefinitions
in "sequoia/sdram.h".  To avoid this, he could use the new version of this
file that my patches create, or (even better IMO), just drop file "sdram.h"
completely, as everything he needs should be in "ppc440.h".

I should have a patch soon that makes this and other changes to
"sequoia/sdram.c" to take advantage of the new code I've submitted.  I
will post it when it is ready.

Best regards,
Larry

 

  reply	other threads:[~2007-12-28 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 13:43 [U-Boot-Users] [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor Larry Johnson
2007-12-28 15:42 ` Stefan Roese
2007-12-28 16:23   ` Larry Johnson [this message]
     [not found]     ` <4775DC12.6020909@arlinx.com>
2007-12-29  8:33       ` Stefan Roese
  -- strict thread matches above, loose matches on Subject: below --
2007-12-22 20:14 Larry Johnson
2007-12-23 10:40 ` Jean-Christophe PLAGNIOL-VILLARD
2007-12-27 12:18   ` Stefan Roese
2007-12-27 17:56     ` Jean-Christophe PLAGNIOL-VILLARD
2007-12-27 12:11 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47752310.4030003@arlinx.com \
    --to=lrj@arlinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox