From mboxrd@z Thu Jan 1 00:00:00 1970 From: gvb.uboot Date: Sat, 29 Dec 2007 07:38:10 -0500 Subject: [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii() In-Reply-To: <477472A3.4020201@necel.com> References: <477472A3.4020201@necel.com> Message-ID: <47763FB2.50508@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Shinya Kuribayashi wrote: > We now have more useful version of do_mii() and everybody use it. Grald > Van Baren says > >> When I originally wrote the mii command 6(!) years ago, I wrote a >> verbose version that printed human readable decomposition of the flags, >> etc., and a terse one that didn't print as much stuff and thus had a >> smaller memory footprint. >> >> It sounds like the terse version has withered and died, apparently >> people are only using the verbose version (which is very understandable, >> I do myself). > > Signed-off-by: Shinya Kuribayashi > Signed-off-by: Gerald Van Baren Hi Shinya, Thanks for the patch to clean this up. While I agree with the patch, I would appreciate respinning it: * I should be an "Acked by" rather than a signed off by since I didn't do anything to generate the patch itself. * I would also offer the following summary rather than quoting my original email (including the 6(!) year reference, which will look kinda funny in 2012 ;-): Remove the "terse" version of the mii command, eliminating an #ifdef and apparently unused code. The space savings of the "terse" version is not significant and it isn't worth the extra maintenance effort to keep it. Acked-by: Gerald Van Baren Thanks, gvb