From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Fri, 04 Jan 2008 07:38:06 -0500 Subject: [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii() In-Reply-To: <477DB676.70406@ruby.dti.ne.jp> References: <477472A3.4020201@necel.com> <47763FB2.50508@gmail.com> <477DB676.70406@ruby.dti.ne.jp> Message-ID: <477E28AE.1020400@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Shinya Kuribayashi wrote: > gvb.uboot wrote: >> Thanks for the patch to clean this up. While I agree with the patch, >> I would appreciate respinning it: >> * I should be an "Acked by" rather than a signed off by since I didn't >> do anything to generate the patch itself. > > As you are the original writer, IMHO you could/should signed-off-by :-) > But it was my bad to add your sign without asking you. I'll resubmit the > patch later with your acked-by. I figure that an acked-by is more appropriate than a signed-off-by because, while I approve of the patch, I didn't actually contribute to it directly (I contributed the anti-patch, that is, the code that is being removed... but that already has my signed-off-by on it). > Thanks for your kind summary. > > Shinya Thanks for rerolling, gvb