public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rafal Jaworowski <raj@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] disabling d-cache in 'bootelf' for QNX
Date: Sun, 06 Jan 2008 15:11:54 +0100	[thread overview]
Message-ID: <4780E1AA.203@semihalf.com> (raw)
In-Reply-To: <20080105195831.036cb6cd@vader.jdub.homelinux.org>

Josh Boyer wrote:
>>>> Yeah, after a second thought I tend to agree. Maybe the way to go is doing
>>>> data cache flush from within dcache_disable() properly i.e. bring it in for
>>>> arch variations that don't do it currently like 85xx... Actually to confirm
>>>> my observations I tested a working patch that flushes d-cache at
>>>> cache_disable() just like 86xx and it works for me, this is: my problems
>>>> disappear. Do you think this is a better option?
>>> Yes, I think this is the way to go. Please provide a patch and send it to the 
>>> 85xx maintainer. Best would be if you could check the other ARCH's (at least 
>>> PPC) for this dcache_disable() behaviour too.
>>>
>> I checked, and only 7xx/74xx, 86xx and 4xx do it properly. For all other PPC
>> variants cache_disable() does not flush d-cache before disabling it... So the
>> problem is quite widespread. I'll try to come up with something generic, but
>> am not sure if it'll fit every other variant.
> 
> Out of curiosity, how do you disable dcache on 44x?  The only way I
> know how to turn the cache off on 440 is to set the Guarded bit in the
> TLB entries.  There is no cache disable bit.
> 

I believe this is how "disabling" is achieved currently in U-Boot: the DRAM
region is TLB-mapped with the G bit set. But I was rather referring to
introducing a d-cache flush as a first step of dcache_disable() in cases it is
not there, and not re-working the disable sequence itself. 440 is special
about this and we probably have to live with d-cache being either always
present or "disabled" via G bit.

> (And from what I see, dcache_disable, icache_disable, and icache_enable
> all just simply return without doing anything on 440).
> 

I mistyped: it is 40x that does flushing before disabling d-cache; on 440, as
you say, there are stubs for these ops.

kind regards,
Rafal

  reply	other threads:[~2008-01-06 14:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 17:40 [U-Boot-Users] disabling d-cache in 'bootelf' for QNX Rafal Jaworowski
2008-01-03 10:16 ` Stefan Roese
2008-01-03 10:30   ` Rafal Jaworowski
2008-01-03 11:12     ` Stefan Roese
2008-01-05 22:18       ` Rafal Jaworowski
2008-01-06  1:58         ` Josh Boyer
2008-01-06 14:11           ` Rafal Jaworowski [this message]
2008-01-07  9:14             ` Matthias Fuchs
2008-01-07  9:35               ` Stefan Roese
2008-01-03 16:45     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4780E1AA.203@semihalf.com \
    --to=raj@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox