public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix Ethernet init() return codes
Date: Tue, 08 Jan 2008 17:07:05 -0500	[thread overview]
Message-ID: <4783F409.5020300@gmail.com> (raw)
In-Reply-To: <4783F29B.4080202@freescale.com>

Timur Tabi wrote:
> Ben Warren wrote:
>> Change return values of init() functions in all Ethernet drivers to 
>> conform
>> to the following:
>>
>>> =0: Success
>> <0:  Failure
>>
>> All drivers going forward should return 0 on success.  Current 
>> drivers that
>> return 1 on success were left as-is to minimize changes.
>>
>> Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
>> ---
>>  cpu/ixp/npe/npe.c        |    8 ++++----
>>  cpu/mpc8xx/fec.c         |    6 +++---
>>  drivers/net/dc2114x.c    |    4 ++--
>>  drivers/net/eepro100.c   |    4 ++--
>>  drivers/net/macb.c       |    4 ++--
>>  drivers/net/pcnet.c      |    4 ++--
>>  drivers/net/rtl8139.c    |    4 ++--
>>  drivers/net/rtl8169.c    |    5 +++--
>>  drivers/net/tsec.c       |    2 +-
>>  drivers/net/tsi108_eth.c |    4 ++--
>>  drivers/net/uli526x.c    |    6 +++---
>>  net/eth.c                |    2 +-
>>  12 files changed, 27 insertions(+), 26 deletions(-)
>
> You forgot drivers/qe/uec.c
>
Arrrghhh!  I only looked in cpu and drivers/net
More on the way, I guess...

regards,
Ben

  parent reply	other threads:[~2008-01-08 22:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08 21:56 [U-Boot-Users] [PATCH] Fix Ethernet init() return codes Ben Warren
2008-01-08 22:00 ` Timur Tabi
2008-01-08 22:07   ` Medve Emilian
2008-01-08 22:07   ` Ben Warren [this message]
2008-01-08 22:02 ` Ben Warren
2008-01-08 22:09   ` Timur Tabi
2008-01-08 22:30     ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4783F409.5020300@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox