[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[stefano babic]

Code is broken for PXA270 due to "invalid lvalue in assignment".

This patch fix it in pxa-regs.h

Signed-off-by: Stefano Babic <sbabic@denx.de>


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0005-Removed-compiler-issue-invalid-lvalue.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070830/f9235461/attachment.txt 

[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[Wolfgang Denk]

In message <46D72D2F.4020601@denx.de> you wrote:
> This is a multi-part message in MIME format.
> --------------030401040309070602030800
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
> Content-Transfer-Encoding: 7bit
> 
> Code is broken for PXA270 due to "invalid lvalue in assignment".
> 
> This patch fix it in pxa-regs.h
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: What do you get when you cross an ethernet with an income statement?
A: A local area networth.

[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[Stefan Herbrechtsmeier]

stefano babic <sbabic <at> denx.de> writes:

> 
> Code is broken for PXA270 due to "invalid lvalue in assignment".
> 
> This patch fix it in pxa-regs.h
> 
> Signed-off-by: Stefano Babic <sbabic <at> denx.de>
> 

This Patch makes wrong calculation!

The real bug can be fixed by using the old style with pointer / address (from
the linux kernel)

#define GPLR(x) 	(*((((x) & 0x7f) < 96) ? &_GPLR(x) : &GPLR3))

or by fixing the calculation

#define GPLR(x)		__REG2(0x40E00000, (((x) & 0x7f) < 96) ?
				((x) & 0x60) >> 3 : 0x100)

Which is the preferred way?

Stefan

[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[Stefan Herbrechtsmeier]

stefano babic <sbabic <at> denx.de> writes:

 >
 > Code is broken for PXA270 due to "invalid lvalue in assignment".
 >
 > This patch fix it in pxa-regs.h
 >
 > Signed-off-by: Stefano Babic <sbabic <at> denx.de>
 >

This Patch makes wrong calculation!

The real bug can be fixed by using the old style with pointer / address 
(from
the linux kernel)

#define GPLR(x)     (*((((x) & 0x7f) < 96) ? &_GPLR(x) : &GPLR3))

or by fixing the calculation

#define GPLR(x)        __REG2(0x40E00000, (((x) & 0x7f) < 96) ?
                ((x) & 0x60) >> 3 : 0x100)

Which is the preferred way?

Stefan

[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[stefano babic]

Stefan Herbrechtsmeier wrote:
> The real bug can be fixed by using the old style with pointer / address (from
> the linux kernel)

You are right and a patch was already sent to fix this problem, only at 
a wrong time and was not accepted (you find it in the list with the 
subject "Fix gcc issues in pxa-regs.h"). It contains the same solution 
as in Kernel. I forget to re-submit the patch, sorry.

Wolfgang has already confirmed to me that he will integrate this patch.

stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[Wolfgang Denk]

In message <4784AFAE.3080505@hni.uni-paderborn.de> you wrote:
> stefano babic <sbabic <at> denx.de> writes:
> 
>  >
>  > Code is broken for PXA270 due to "invalid lvalue in assignment".
>  >
>  > This patch fix it in pxa-regs.h
>  >
>  > Signed-off-by: Stefano Babic <sbabic <at> denx.de>
>  >
> 
> This Patch makes wrong calculation!

Which specific patch are you referring to? I think what you refer to
has been obsoleted by Stefnao's postings on Nov 11:

11/20 stefano babic      [U-Boot-Users] [PATCH] Fix gcc issues in pxa-regs.h

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No problem is insoluble.
	-- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4

[U-Boot-Users] [PATCH] Removed compiler issue (invalid lvalue) - CPU PXA270

[Stefan Herbrechtsmeier]

Sorry, I don't know this patch and I only saw, that it was not fix in 
version 1.3.1 or the git tree.

Stefan

Wolfgang Denk schrieb:
> In message <4784AFAE.3080505@hni.uni-paderborn.de> you wrote:
>   
>> stefano babic <sbabic <at> denx.de> writes:
>>
>>  >
>>  > Code is broken for PXA270 due to "invalid lvalue in assignment".
>>  >
>>  > This patch fix it in pxa-regs.h
>>  >
>>  > Signed-off-by: Stefano Babic <sbabic <at> denx.de>
>>  >
>>
>> This Patch makes wrong calculation!
>>     
>
> Which specific patch are you referring to? I think what you refer to
> has been obsoleted by Stefnao's postings on Nov 11:
>
> 11/20 stefano babic      [U-Boot-Users] [PATCH] Fix gcc issues in pxa-regs.h
>
> Best regards,
>
> Wolfgang Denk
>
>   


-- 
Dipl.-Ing. Stefan Herbrechtsmeier

Heinz Nixdorf Institute
University of Paderborn 
System and Circuit Technology 
F?rstenallee 11
D-33102 Paderborn (Germany)

office : F0.415
phone  : + 49 5251 - 60 6342
fax    : + 49 5251 - 60 6351

mailto : hbmeier at hni.upb.de

www    : http://wwwhni.upb.de/sct/mitarbeiter/hbmeier