From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH V2] Fix Ethernet init() return codes.
Date: Wed, 09 Jan 2008 16:37:36 -0500 [thread overview]
Message-ID: <47853EA0.80008@gmail.com> (raw)
In-Reply-To: <20080109213056.75361242E7@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Ben,
>
> in message <4784FDFE.8030801@gmail.com> you wrote:
>
>> Kim Phillips wrote:
>>
>>> On Wed, 9 Jan 2008 05:58:33 +0100
>>> Stefan Roese <sr@denx.de> wrote:
>>>
>>>
>>>
>>>> On Tuesday 08 January 2008, Ben Warren wrote:
>>>>
>>>>
>>>>> Change return values of init() functions in all Ethernet drivers to conform
>>>>>
>>>>> to the following:
>>>>> >=0: Success
>>>>>
>>>>> <0: Failure
>>>>>
>>>>> All drivers going forward should return 0 on success. Current drivers that
>>>>> return 1 on success were left as-is to minimize changes.
>>>>>
>>>>> Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
>>>>>
>>>>>
>>>> Acked-by: Stefan Roese <sr@denx.de>
>>>>
>>>>
>>> for both qe and tsec based devices:
>>>
>>> Acked-by: Kim Phillips <kim.phillips@freescale.com>
>>>
>>> this should be applied asap
>>>
>>> Kim
>>>
>>>
>>>
>> Please apply directly.
>>
>
> Which one? The original "[PATCH V2] Fix Ethernet init() return codes"
> patch?
>
> Best regards,
>
> Wolfgang Denk
>
>
Yes, the original V2 patch, not the one before it since it missed QE.
regards,
Ben
next prev parent reply other threads:[~2008-01-09 21:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 22:23 [U-Boot-Users] [PATCH V2] Fix Ethernet init() return codes Ben Warren
2008-01-09 4:58 ` Stefan Roese
2008-01-09 15:18 ` Kim Phillips
2008-01-09 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-09 17:01 ` Ben Warren
2008-01-09 21:30 ` Wolfgang Denk
2008-01-09 21:37 ` Ben Warren [this message]
2008-01-09 21:50 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-09 22:19 ` Ben Warren
2008-01-09 22:43 ` Wolfgang Denk
2008-01-09 22:48 ` Ben Warren
2008-01-09 16:14 ` Timur Tabi
2008-01-09 16:26 ` Haavard Skinnemoen
2008-01-09 18:26 ` Ulf Samuelsson
2008-01-09 22:01 ` Wolfgang Denk
2008-01-10 0:11 ` Ulf Samuelsson
2008-01-10 8:01 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47853EA0.80008@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox