From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Wed, 09 Jan 2008 16:37:36 -0500 Subject: [U-Boot-Users] [PATCH V2] Fix Ethernet init() return codes. In-Reply-To: <20080109213056.75361242E7@gemini.denx.de> References: <20080109213056.75361242E7@gemini.denx.de> Message-ID: <47853EA0.80008@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Ben, > > in message <4784FDFE.8030801@gmail.com> you wrote: > >> Kim Phillips wrote: >> >>> On Wed, 9 Jan 2008 05:58:33 +0100 >>> Stefan Roese wrote: >>> >>> >>> >>>> On Tuesday 08 January 2008, Ben Warren wrote: >>>> >>>> >>>>> Change return values of init() functions in all Ethernet drivers to conform >>>>> >>>>> to the following: >>>>> >=0: Success >>>>> >>>>> <0: Failure >>>>> >>>>> All drivers going forward should return 0 on success. Current drivers that >>>>> return 1 on success were left as-is to minimize changes. >>>>> >>>>> Signed-off-by: Ben Warren >>>>> >>>>> >>>> Acked-by: Stefan Roese >>>> >>>> >>> for both qe and tsec based devices: >>> >>> Acked-by: Kim Phillips >>> >>> this should be applied asap >>> >>> Kim >>> >>> >>> >> Please apply directly. >> > > Which one? The original "[PATCH V2] Fix Ethernet init() return codes" > patch? > > Best regards, > > Wolfgang Denk > > Yes, the original V2 patch, not the one before it since it missed QE. regards, Ben