From mboxrd@z Thu Jan 1 00:00:00 1970 From: gvb.uboot Date: Sat, 12 Jan 2008 12:29:48 -0500 Subject: [U-Boot-Users] [PATCH] Fix "i2c sdram" command for DDR2 DIMMs In-Reply-To: <4786E13B.3030105@acm.org> References: <4786E13B.3030105@acm.org> Message-ID: <4788F90C.5000501@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Larry Johnson wrote: > Many of the SPD bytes for DDR2 SDRAM are not interpreted correctly by the > "i2c sdram" command. This patch provides correct alternative > interpretations when DDR2 memory is detected. > > Signed-off-by: Larry Johnson > --- > Hi Wolfgang and Stefan and group, > > In this patch, I have fixed the DDR2 output for the SPD bytes currently > displayed by the "i2c sdram". I have not added any display for the > additional bytes defined in DDR2; I may do that later when I have time. > > I don't have any way of testing the patched code for non-DDR2 memory, but > if I force the code to treat the DDR2 memory type as "unknown", I get the > same values as before the patch. > > Stefan, the added size of this causes a section overlap on the Luan board, > and makes the existing overlap on the Ocotea board worse. > > If memory size is critical, I could redo this patch using conditional > compilation for different memory types, though I believe this would add > complexity and reduce flexibility. If you would prefer this, please let > me know. > > Best regards, > Larry Verified that the code prints the same thing for SDRAM (sacsng board) before and after Larry's patches (including "Refactor code for "i2c sdram" command") other than some gratuitous ;-) s/nS/ns/ s/uS/us/. Acked-by: Gerald Van Baren Thanks, gvb