[U-Boot-Users] [PATCH] NAND: Change nand_wait_ready() to not call nand_wait()

[U-Boot-Users] [PATCH] NAND: Change nand_wait_ready() to not call nand_wait()

[Stefan Roese]

This patch changes nand_wait_ready() to not just call nand_wait(),
since this will send a new command to the NAND chip. We just want to
wait for the chip to become ready here.

Signed-off-by: Stefan Roese <sr@denx.de>
---
William & Stig, could you please review this patch and test it on your
platforms?

Thanks.

 drivers/mtd/nand/nand_base.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 5a8196e..6c5c794 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -489,7 +489,16 @@ EXPORT_SYMBOL_GPL(nand_wait_ready);
 void nand_wait_ready(struct mtd_info *mtd)
 {
 	struct nand_chip *chip = mtd->priv;
-	nand_wait(mtd, chip);
+	u32 timeo = (CFG_HZ * 20) / 1000;
+
+	reset_timer();
+
+	/* wait until command is processed or timeout occures */
+	while (get_timer(0) < timeo) {
+		if (chip->dev_ready)
+			if (chip->dev_ready(mtd))
+				break;
+	}
 }
 #endif
 
-- 
1.5.4.rc2

[U-Boot-Users] NAND driver updates

[Stefan Roese]

Hi All,

I just updated the master branch of the NAND custodian repository with the 
patches from William Juul:

http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=shortlog;h=master

This patchset brings the U-Boot NAND subsystem in sync again with the Linux 
2.6.22.1 NAND code. Thanks go to William Juul and his colleagues for the hard 
work. Here again the comments from his first announcement mail on 2007-11-07:

> Update MTD to that of Linux 2.6.22.1
>
> A lot changed in the Linux MTD code, since it was last ported from
> Linux to U-Boot. This patch takes U-Boot NAND support to the level
> of Linux 2.6.22.1 and will enable support for very large NAND devices
> (4KB pages) and ease the compatibility between U-Boot and Linux
> filesystems and drivers.
>
> This patch is tested on two custom boards with PPC and ARM
> processors running YAFFS in U-Boot and Linux using gcc-4.1.2
> cross compilers.
>
> MAKEALL ppc/arm has some issues:
> ?* DOC/OneNand/nand_spl is not building (I have not tried porting
> ? ?these parts, and since I do not have any HW and I am not familiar
> ? ?with this code/HW I think its best left to someone else.)
>
> Except for the issues mentioned above, I have ported all drivers
> necessary to run MAKEALL ppc/arm without errors and warnings. Many
> drivers were trivial to port, but some were not so trivial. The
> following drivers must be examined carefully and maybe rewritten to
> some degree:
> ?cpu/ppc4xx/ndfc.c
> ?cpu/arm926ejs/davinci/nand.c
> ?board/delta/nand.c
> ?board/zylonite/nand.c

I changed the 4xx NAND driver (ndfc) and the nand_spl driver to match the 
changes subsystem. Please change and test your other NAND drivers too. This 
should not be so difficult, since now the NAND drivers are in-sync again with 
the Linux MTD drivers. So look how it is done there in the current drivers 
and you should know what to do.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] NAND driver updates

[Matthias Fuchs]

Hi Stefan,

the updated NAND code lacks support for the CFG_NAND_QUIET_TEST
behavior. This is currently used by the 'alpr' board and soon by the
PMC440 (patch will be submitted in just a minute).

Matthias

On Saturday 05 January 2008 17:15, Stefan Roese wrote:
> Hi All,
> 
> I just updated the master branch of the NAND custodian repository with the 
> patches from William Juul:
> 
> http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=shortlog;h=master
> 
> This patchset brings the U-Boot NAND subsystem in sync again with the Linux 
> 2.6.22.1 NAND code. Thanks go to William Juul and his colleagues for the hard 
> work. Here again the comments from his first announcement mail on 2007-11-07:
> 
> > Update MTD to that of Linux 2.6.22.1
> >
> > A lot changed in the Linux MTD code, since it was last ported from
> > Linux to U-Boot. This patch takes U-Boot NAND support to the level
> > of Linux 2.6.22.1 and will enable support for very large NAND devices
> > (4KB pages) and ease the compatibility between U-Boot and Linux
> > filesystems and drivers.
> >
> > This patch is tested on two custom boards with PPC and ARM
> > processors running YAFFS in U-Boot and Linux using gcc-4.1.2
> > cross compilers.
> >
> > MAKEALL ppc/arm has some issues:
> > ?* DOC/OneNand/nand_spl is not building (I have not tried porting
> > ? ?these parts, and since I do not have any HW and I am not familiar
> > ? ?with this code/HW I think its best left to someone else.)
> >
> > Except for the issues mentioned above, I have ported all drivers
> > necessary to run MAKEALL ppc/arm without errors and warnings. Many
> > drivers were trivial to port, but some were not so trivial. The
> > following drivers must be examined carefully and maybe rewritten to
> > some degree:
> > ?cpu/ppc4xx/ndfc.c
> > ?cpu/arm926ejs/davinci/nand.c
> > ?board/delta/nand.c
> > ?board/zylonite/nand.c
> 
> I changed the 4xx NAND driver (ndfc) and the nand_spl driver to match the 
> changes subsystem. Please change and test your other NAND drivers too. This 
> should not be so difficult, since now the NAND drivers are in-sync again with 
> the Linux MTD drivers. So look how it is done there in the current drivers 
> and you should know what to do.
> 
> Thanks.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> 
> 

-- 
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
SD4

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Telefon: 0511-37298-0 - Fax: 0511-37298-68
Bitte besuchen Sie uns im Internet unter http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------

[U-Boot-Users] NAND driver updates

[ksi at koi8.net]

On Sat, 5 Jan 2008, Stefan Roese wrote:

Here comes a trivial patch to cpu/arm926ejs/davinci/nand.c. Unfortunately I
don't have hardware handy so I can not test it at the moment but changes are
rather trivial so it should work. It would be nice if somebody with a
hardware checked it anyways.

Signed-off-by: Sergey Kubushyn <ksi@koi8.net>

--
diff --git a/cpu/arm926ejs/davinci/nand.c b/cpu/arm926ejs/davinci/nand.c
index 0a612de..0f11f55 100644
--- a/cpu/arm926ejs/davinci/nand.c
+++ b/cpu/arm926ejs/davinci/nand.c
@@ -89,18 +89,25 @@ static void nand_davinci_select_chip(struct mtd_info *mtd, int chip)

  #ifdef CFG_NAND_HW_ECC
  #ifdef CFG_NAND_LARGEPAGE
-static struct nand_oobinfo davinci_nand_oobinfo = {
-	.useecc = MTD_NANDECC_AUTOPLACE,
+static struct nand_ecclayout davinci_nand_ecclayout = {
  	.eccbytes = 12,
  	.eccpos = {8, 9, 10, 24, 25, 26, 40, 41, 42, 56, 57, 58},
-	.oobfree = { {2, 6}, {12, 12}, {28, 12}, {44, 12}, {60, 4} }
+	.oobfree = {
+		{.offset = 2, .length = 6},
+		{.offset = 12, .length = 12},
+		{.offset = 28, .length = 12},
+		{.offset = 44, .length = 12},
+		{.offset = 60, .length = 4}
+	}
  };
  #elif defined(CFG_NAND_SMALLPAGE)
-static struct nand_oobinfo davinci_nand_oobinfo = {
-	.useecc = MTD_NANDECC_AUTOPLACE,
+static struct nand_ecclayout davinci_nand_ecclayout = {
  	.eccbytes = 3,
  	.eccpos = {0, 1, 2},
-	.oobfree = { {6, 2}, {8, 8} }
+	.oobfree = {
+		{.offset = 6, .length = 2},
+		{.offset = 8, .length = 8}
+	}
  };
  #else
  #error "Either CFG_NAND_LARGEPAGE or CFG_NAND_SMALLPAGE must be defined!"
@@ -369,7 +376,7 @@ int board_nand_init(struct nand_chip *nand)
  #else
  #error "Either CFG_NAND_LARGEPAGE or CFG_NAND_SMALLPAGE must be defined!"
  #endif
-/*	nand->autooob	  = &davinci_nand_oobinfo; */
+	nand->ecc.layout  = &davinci_nand_ecclayout;
  	nand->ecc.calculate = nand_davinci_calculate_ecc;
  	nand->ecc.correct  = nand_davinci_correct_data;
  	nand->ecc.hwctl  = nand_davinci_enable_hwecc;


---
******************************************************************
*  KSI at home    KOI8 Net  < >  The impossible we do immediately.  *
*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
******************************************************************

[U-Boot-Users] NAND driver updates

[Dirk Behme]

ksi at koi8.net wrote:
> On Sat, 5 Jan 2008, Stefan Roese wrote:
> 
> Here comes a trivial patch to cpu/arm926ejs/davinci/nand.c. Unfortunately I
> don't have hardware handy so I can not test it at the moment but changes are
> rather trivial so it should work. It would be nice if somebody with a
> hardware checked it anyways.

Seems okay. I wrote the same image to location A in NAND with mainline 
U-Boot and to location B using recent u-boot-nand-flash.git. Then read 
both locations back to SDRAM and cmp was happy. A short look to ECCs 
using nand dump looked okay as well.

Many thanks

Dirk

Btw: Any idea why erase percentage output is so strange? "200% complete"?

 > nand info

Device 0: NAND 64MiB 1,8V 8-bit, sector size 16 KiB

 > nand erase 0x100000 0x2000

NAND erase: device 0 offset 0x100000, size 0x2000
Erasing at 0x100000 -- 200% complete.
OK
 >

[U-Boot-Users] NAND driver updates

[ksi at koi8.net]

On Sun, 13 Jan 2008, Dirk Behme wrote:

> ksi at koi8.net wrote:
>> On Sat, 5 Jan 2008, Stefan Roese wrote:
>> 
>> Here comes a trivial patch to cpu/arm926ejs/davinci/nand.c.
> Unfortunately I
>> don't have hardware handy so I can not test it at the moment but
> changes 
>> are
>> rather trivial so it should work. It would be nice if somebody with a
>> hardware checked it anyways.
>
> Seems okay. I wrote the same image to location A in NAND with mainline
> U-Boot 
> and to location B using recent u-boot-nand-flash.git. Then read both 
> locations back to SDRAM and cmp was happy. A short look to ECCs using
> nand 
> dump looked okay as well.

OK, thanks. Nice to hear...

> Many thanks
>
> Dirk
>
> Btw: Any idea why erase percentage output is so strange? "200%
> complete"?
>
>> nand info
>
> Device 0: NAND 64MiB 1,8V 8-bit, sector size 16 KiB
>
>> nand erase 0x100000 0x2000
>
> NAND erase: device 0 offset 0x100000, size 0x2000
> Erasing at 0x100000 -- 200% complete.
> OK

Have no idea... Something should be broken in that new NAND code...

---
******************************************************************
*  KSI at home    KOI8 Net  < >  The impossible we do immediately.  *
*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
******************************************************************

[U-Boot-Users] NAND driver updates

[Matthias Fuchs]

Hi Stefan,

I tested your updated NAND repo on a PLU405 board (405EP with small block NAND attached to EBC+GPIOs).

I found two more issues and incompatibilities against the current mainline code:

1) The new code is much more noisy during startup:
Old:
...
DRAM:  32 MB
FLASH:  1 MB
NAND:  32 MiB
PCI:   Bus Dev VenId DevId Class Int
...

New:
...
FLASH:  1 MB
NAND:  NAND device: Manufacturer ID: 0xec, Chip ID: 0x75 (Samsung NAND 32MiB 3,3V 8-bit)
Scanning device for bad blocks
Bad eraseblock 261 at 0x00414000
Bad eraseblock 352 at 0x00580000
Bad eraseblock 846 at 0x00d38000
Bad eraseblock 848 at 0x00d40000
32 MiB
PCI:   Bus Dev VenId DevId Class Int
...

Perhaps we should calme is down by using the option 'CFG_NAND_QUIET_TEST'.
Also the formatting of the output is not very pretty.

2) 'nand read.jffs2' and 'nand read.i' do not read anything.
'nand read' is ok. Are there any boards where you tested this ok?

Matthias

On Saturday 05 January 2008 17:15, Stefan Roese wrote:
> Hi All,
> 
> I just updated the master branch of the NAND custodian repository with the 
> patches from William Juul:
> 
> http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=shortlog;h=master
> 
> This patchset brings the U-Boot NAND subsystem in sync again with the Linux 
> 2.6.22.1 NAND code. Thanks go to William Juul and his colleagues for the hard 
> work. Here again the comments from his first announcement mail on 2007-11-07:

[U-Boot-Users] NAND driver updates

[Stefan Roese]

Hi Matthias,

On Thursday 10 January 2008, Matthias Fuchs wrote:
> I tested your updated NAND repo on a PLU405 board (405EP with small block
> NAND attached to EBC+GPIOs).
>
> I found two more issues and incompatibilities against the current mainline
> code:
>
> 1) The new code is much more noisy during startup:
> Old:
> ...
> DRAM:  32 MB
> FLASH:  1 MB
> NAND:  32 MiB
> PCI:   Bus Dev VenId DevId Class Int
> ...
>
> New:
> ...
> FLASH:  1 MB
> NAND:  NAND device: Manufacturer ID: 0xec, Chip ID: 0x75 (Samsung NAND
> 32MiB 3,3V 8-bit) Scanning device for bad blocks
> Bad eraseblock 261 at 0x00414000
> Bad eraseblock 352 at 0x00580000
> Bad eraseblock 846 at 0x00d38000
> Bad eraseblock 848 at 0x00d40000
> 32 MiB
> PCI:   Bus Dev VenId DevId Class Int
> ...
>
> Perhaps we should calme is down by using the option 'CFG_NAND_QUIET_TEST'.
> Also the formatting of the output is not very pretty.

Yes, we should remove those lines. I suggest to use debug() for here, so that 
they are printed when DEBUG is defined.

> 2) 'nand read.jffs2' and 'nand read.i' do not read anything.
> 'nand read' is ok. Are there any boards where you tested this ok?

No, I didn't test this. IIRC there is still a TODO in the source that this 
still has to be implemented/tested. It shouldn't be that hard though. I would 
really appreciate it if you (or somebody else) could take a look at this.

Thanks.

BTW: I'm not available today.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] NAND driver updates

[Stefan Roese]

On Thursday 10 January 2008, Stefan Roese wrote:
> > New:
> > ...
> > FLASH:  1 MB
> > NAND:  NAND device: Manufacturer ID: 0xec, Chip ID: 0x75 (Samsung NAND
> > 32MiB 3,3V 8-bit) Scanning device for bad blocks
> > Bad eraseblock 261 at 0x00414000
> > Bad eraseblock 352 at 0x00580000
> > Bad eraseblock 846 at 0x00d38000
> > Bad eraseblock 848 at 0x00d40000
> > 32 MiB
> > PCI:   Bus Dev VenId DevId Class Int
> > ...
> >
> > Perhaps we should calme is down by using the option
> > 'CFG_NAND_QUIET_TEST'. Also the formatting of the output is not very
> > pretty.
>
> Yes, we should remove those lines. I suggest to use debug() for here, so
> that they are printed when DEBUG is defined.

I already changed this in the NAND custodian repo.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] NAND driver updates

[Stefan Roese]

Hi All,

On Saturday 05 January 2008, Stefan Roese wrote:
> I just updated the master branch of the NAND custodian repository with the
> patches from William Juul:
>
> http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=shor
>tlog;h=master
>
> This patchset brings the U-Boot NAND subsystem in sync again with the Linux
> 2.6.22.1 NAND code. Thanks go to William Juul and his colleagues for the
> hard

As it seems the current status of the new NAND subsystem provided by William 
Juul and his colleges, has still some problems. As far as I see it right now 
here a list (please let me know if I missed something):

- DOC support broken and removed for now
  - needs to be ported and tested on HW with DOC
- 'nand read.jffs2/.i' not implemented at all
- 'nand write.jffs2/.i' not implemented correctly
  - Doesn't skip bad blocks
  - From my quick first look, it doesn't write the OOB correctly
- Extensive testing on other platforms needed

So with all these flaws, it doesn't make sense from my point of view, to pull 
these changes into the official U-Boot repository in this merge window. I 
think we should delay this merge for 1 or 2 U-Boot versions, until the 
problems mentioned above are resolved.

Any thoughts/comments on this?

If we agree on this merge delay, then I suggest that I move this mtd update 
into a different branch (it's currently in the master branch :-() of the 
u-boot-nand-flash repository and base the master branch on the master branch 
of Wolfgang's official repository. This way updates and fixes to the "old" 
NAND subsystem can be handled better.

Again, any comments?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] NAND driver updates

[Matthias Fuchs]

Hi Stefan,

I totally agree with your suggestion. Let's move the NAND update into 
a separate branch for testing.

The missing or faulty NAND features are an absolute no-go because we
use NAND on many of our boards. But we definitely should not lose track
of the NAND updates. Especially William's YAFFS support is a cool outstanding
feature I would love to see in the main repo sooner or later.

Matthias

On Tuesday 15 January 2008 09:49, Stefan Roese wrote:
> Hi All,
> 
> On Saturday 05 January 2008, Stefan Roese wrote:
> > I just updated the master branch of the NAND custodian repository with the
> > patches from William Juul:
> >
> > http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=shor
> >tlog;h=master
> >
> > This patchset brings the U-Boot NAND subsystem in sync again with the Linux
> > 2.6.22.1 NAND code. Thanks go to William Juul and his colleagues for the
> > hard
> 
> As it seems the current status of the new NAND subsystem provided by William 
> Juul and his colleges, has still some problems. As far as I see it right now 
> here a list (please let me know if I missed something):
> 
> - DOC support broken and removed for now
>   - needs to be ported and tested on HW with DOC
> - 'nand read.jffs2/.i' not implemented at all
> - 'nand write.jffs2/.i' not implemented correctly
>   - Doesn't skip bad blocks
>   - From my quick first look, it doesn't write the OOB correctly
> - Extensive testing on other platforms needed
> 
> So with all these flaws, it doesn't make sense from my point of view, to pull 
> these changes into the official U-Boot repository in this merge window. I 
> think we should delay this merge for 1 or 2 U-Boot versions, until the 
> problems mentioned above are resolved.
> 
> Any thoughts/comments on this?
> 
> If we agree on this merge delay, then I suggest that I move this mtd update 
> into a different branch (it's currently in the master branch :-() of the 
> u-boot-nand-flash repository and base the master branch on the master branch 
> of Wolfgang's official repository. This way updates and fixes to the "old" 
> NAND subsystem can be handled better.
> 
> Again, any comments?
> 
> Thanks.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> 
> 

-- 
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
SD4

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Telefon: 0511-37298-0 - Fax: 0511-37298-68
Bitte besuchen Sie uns im Internet unter http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------

[U-Boot-Users] NAND driver updates

[Stig A. Olsen]

Hi,

I think you're absolutely right as well, better to branch out our 
updates until we have resolved these issues. Since YAFFS/MTD is new, 
most people will depend on jffs2 working, and that must be working 
before introducing changes.

best regards,
Stig

Matthias Fuchs wrote:
> Hi Stefan,
>
> I totally agree with your suggestion. Let's move the NAND update into 
> a separate branch for testing.
>
> The missing or faulty NAND features are an absolute no-go because we
> use NAND on many of our boards. But we definitely should not lose track
> of the NAND updates. Especially William's YAFFS support is a cool outstanding
> feature I would love to see in the main repo sooner or later.
>
> Matthias
>
> On Tuesday 15 January 2008 09:49, Stefan Roese wrote:
>   
>> Hi All,
>>
>> On Saturday 05 January 2008, Stefan Roese wrote:
>>     
>>> I just updated the master branch of the NAND custodian repository with the
>>> patches from William Juul:
>>>
>>> http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=shor
>>> tlog;h=master
>>>
>>> This patchset brings the U-Boot NAND subsystem in sync again with the Linux
>>> 2.6.22.1 NAND code. Thanks go to William Juul and his colleagues for the
>>> hard
>>>       
>> As it seems the current status of the new NAND subsystem provided by William 
>> Juul and his colleges, has still some problems. As far as I see it right now 
>> here a list (please let me know if I missed something):
>>
>> - DOC support broken and removed for now
>>   - needs to be ported and tested on HW with DOC
>> - 'nand read.jffs2/.i' not implemented at all
>> - 'nand write.jffs2/.i' not implemented correctly
>>   - Doesn't skip bad blocks
>>   - From my quick first look, it doesn't write the OOB correctly
>> - Extensive testing on other platforms needed
>>
>> So with all these flaws, it doesn't make sense from my point of view, to pull 
>> these changes into the official U-Boot repository in this merge window. I 
>> think we should delay this merge for 1 or 2 U-Boot versions, until the 
>> problems mentioned above are resolved.
>>
>> Any thoughts/comments on this?
>>
>> If we agree on this merge delay, then I suggest that I move this mtd update 
>> into a different branch (it's currently in the master branch :-() of the 
>> u-boot-nand-flash repository and base the master branch on the master branch 
>> of Wolfgang's official repository. This way updates and fixes to the "old" 
>> NAND subsystem can be handled better.
>>
>> Again, any comments?
>>
>> Thanks.
>>
>> Best regards,
>> Stefan
>>
>> =====================================================================
>> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
>> =====================================================================
>>
>>
>>     
>
>   


-- 
Stig A. Olsen
TANDBERG R&D
Mobile: +47 98290058
Phone:  +47 67587418
E-mail: stig.olsen at tandberg.com
http://www.tandberg.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080115/326b803b/attachment.htm 

[U-Boot-Users] NAND driver updates

[ksi at koi8.net]

On Tue, 15 Jan 2008, Stefan Roese wrote:

I totally agree. All those problems should be addressed first and all the
functionality must be restored before propagating it into the main branch.

> Hi All,
>
> On Saturday 05 January 2008, Stefan Roese wrote:
>> I just updated the master branch of the NAND custodian repository with
> the
>> patches from William Juul:
>>
>>
> http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=s
> hor
>> tlog;h=master
>>
>> This patchset brings the U-Boot NAND subsystem in sync again with the
> Linux
>> 2.6.22.1 NAND code. Thanks go to William Juul and his colleagues for
> the
>> hard
>
> As it seems the current status of the new NAND subsystem provided by
> William
> Juul and his colleges, has still some problems. As far as I see it right
> now
> here a list (please let me know if I missed something):
>
> - DOC support broken and removed for now
>  - needs to be ported and tested on HW with DOC
> - 'nand read.jffs2/.i' not implemented at all
> - 'nand write.jffs2/.i' not implemented correctly
>  - Doesn't skip bad blocks
>  - From my quick first look, it doesn't write the OOB correctly
> - Extensive testing on other platforms needed
>
> So with all these flaws, it doesn't make sense from my point of view, to
> pull
> these changes into the official U-Boot repository in this merge window.
> I
> think we should delay this merge for 1 or 2 U-Boot versions, until the
> problems mentioned above are resolved.
>
> Any thoughts/comments on this?
>
> If we agree on this merge delay, then I suggest that I move this mtd
> update
> into a different branch (it's currently in the master branch :-() of the
> u-boot-nand-flash repository and base the master branch on the master
> branch
> of Wolfgang's official repository. This way updates and fixes to the
> "old"
> NAND subsystem can be handled better.
>
> Again, any comments?
>
> Thanks.
>
> Best regards,
> Stefan
>
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
>

---
******************************************************************
*  KSI at home    KOI8 Net  < >  The impossible we do immediately.  *
*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
******************************************************************

[U-Boot-Users] NAND driver updates

[Stefan Roese]

On Tuesday 15 January 2008, Stefan Roese wrote:
> As it seems the current status of the new NAND subsystem provided by
> William Juul and his colleges, has still some problems. As far as I see it
> right now here a list (please let me know if I missed something):
>
> - DOC support broken and removed for now
>   - needs to be ported and tested on HW with DOC
> - 'nand read.jffs2/.i' not implemented at all
> - 'nand write.jffs2/.i' not implemented correctly
>   - Doesn't skip bad blocks
>   - From my quick first look, it doesn't write the OOB correctly
> - Extensive testing on other platforms needed
>
> So with all these flaws, it doesn't make sense from my point of view, to
> pull these changes into the official U-Boot repository in this merge
> window. I think we should delay this merge for 1 or 2 U-Boot versions,
> until the problems mentioned above are resolved.
>
> Any thoughts/comments on this?
>
> If we agree on this merge delay, then I suggest that I move this mtd update
> into a different branch (it's currently in the master branch :-() of the
> u-boot-nand-flash repository and base the master branch on the master
> branch of Wolfgang's official repository. This way updates and fixes to the
> "old" NAND subsystem can be handled better.

I just updated the NAND custodian git repository. It got completely reset 
because I had to restructure the master branch to not include the new MTD 
infrastructure for now. So I suggest, anybody using the u-boot-nand-flash 
custodian repository should clone this repository from scratch.

Here is the new repository layout:

master branch:
Changed, additions and bug fixes to the current "stable" nand subsystem

mtd-2.6.22.1 branch:
Merge of the Linux 2.6.22.1 MTD subsystem with additional changes and YAFFS2 
support

But please keep on testing the new mtd branch and please also send fixes for 
the still missing/broken issues, so that we can merge it into mainline in the 
not too far future.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================