public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller
Date: Sun, 13 Jan 2008 23:04:22 -0500	[thread overview]
Message-ID: <478ADF46.2090902@gmail.com> (raw)
In-Reply-To: <58A20A281BAF1047B4EAE68DE5C0BDC2C0E411@zch01exm21.fsl.freescale.net>

Liu Dave wrote:
>>>> +typedef struct spi834x
>>>> +{
>>>> +       u8 res0[0x20];  /* 0x0-0x01f reserved */
>>>> +       u32 mode;       /* mode register  */
>>>> +       u32 event;      /* event register */
>>>> +       u32 mask;       /* mask register  */
>>>> +       u32 com;        /* command register */
>>>> +       u32 tx;         /* transmit register */
>>>> +       u32 rx;         /* receive register */
>>>> +       u8 res1[0xC8];  /* fill up to 0x100 */
>>>> + } spi834x_t;
>>>>     
>>>>         
>>> please put this into fsl_spi.h to reuse for different 8xxx family.
>>>   
>>>       
>> Can you confirm that the registers in 85xx are the same?  If so, I'll 
>> move this.
>>     
>
> Ben, at lease the 8610 has the same SPI as 834x.
>
> The 8360 and 8568 with CPU mode have likely SPI as 834x.
>   
I just looked up the RM for 8360, and for some reason its register 
offsets are a *bit* different than the 8349. I'll move this struct to 
fsl_spi.h, but we'll have to do some #ifdef magic to work with multiple 
processors, I guess.

regards,
Ben

  reply	other threads:[~2008-01-14  4:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-13  2:48 [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPI controller Ben Warren
2008-01-14  3:24 ` [U-Boot-Users] [PATCH 1/2] Add support for a Freescale non-CPM SPIcontroller Dave Liu
2008-01-14  3:32   ` Ben Warren
2008-01-14  3:46     ` Liu Dave
2008-01-14  4:04       ` Ben Warren [this message]
2008-01-14  4:37       ` Ben Warren
2008-01-14  4:44         ` Liu Dave
2008-01-14  4:48           ` Ben Warren
2008-01-14  5:00           ` Ben Warren
2008-01-14  5:03             ` Liu Dave
2008-01-14  6:09   ` Wolfgang Denk
2008-01-14 15:19     ` Ben Warren
2008-01-15  2:59       ` Dave Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478ADF46.2090902@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox