public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Enable the isdram command on	the	MPC8360EMDS board
Date: Mon, 14 Jan 2008 16:08:51 -0500	[thread overview]
Message-ID: <478BCF63.6080804@ge.com> (raw)
In-Reply-To: <1200340269.5251.6.camel@ld0161-tx32>

Jon Loeliger wrote:
> On Sat, 2008-01-12 at 12:24, Jerry Van Baren wrote:
> 
>> Hi Kim,
>>
>> The isdram command is controlled separately from the rest of the i2c
>> commands (CONFIG_CMD_I2C + CONFIG_CMD_SDRAM).  I did this originally
>> because the isdram command was arguably a memory consuming luxury.
>> Luxuries tend to become necessities over time...
>>
>> Larry Johnson submitted a patch yesterday to extend the decoding and
>> printout to include DDR2 fields, making this even more useful (and jdl
>> is claiming a share of the credit ;-).
>>
>> gvb
> 
> I'm not claiming any credit for it, but if I do the
> following command:
> 
>     $ git show d9b94f28a442b001 -- cpu/mpc85xx/spd_sdram.c
> 
> Someone who impersonated me quite well appears to have
> checked in whole bunch of DDR2 decode stuff way back in
> July of 2005.

[snip]

> Weird, huh?
> 
> jdl

Hi Jon,

I'm kinda loosing the thread here.  I think we are talking about two 
totally different decodes of the same data.

What I'm crediting Larry for isn't the decoding you are pointing to. 
You did machine decoding to make the DDR2 _work,_ which is invaluable.

Larry did the decoding to improve the human-readable output of the 
"isdram" command.  This isn't invaluable in quite the same way, but 
still is really nice to be able to dump the SPD and decode it into ASCII 
for the poor developer.  I don't know if your board(s) have 
CONFIG_CMD_SDRAM defined (it is off by default) - doesn't look like it. 
  If not, turn it on and try it out.

Best regards,
gvb

  reply	other threads:[~2008-01-14 21:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-12 18:24 [U-Boot-Users] [PATCH] Enable the isdram command on the MPC8360EMDS board Jerry Van Baren
2008-01-14 19:51 ` Jon Loeliger
2008-01-14 21:08   ` Jerry Van Baren [this message]
2008-01-14 22:26 ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478BCF63.6080804@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox