[U-Boot-Users] QE UEC driver compiler warnings...

[U-Boot-Users] QE UEC driver compiler warnings...

[Wolfgang Denk]

Dear Dave,

the QE UEC driver (in the top-of-tree version as of now) produces a
few compiler warnings:

qe.c: In function 'qe_upload_firmware':
qe.c:390: warning: pointer targets in passing argument 2 of 'strcpy' differ in signedness
uec.c: In function 'uec_initialize':
uec.c:1236: warning: 'uec_info' may be used uninitialized in this function


Please fix.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Things are not as simple as they seem at first.        - Edward Thorp

[U-Boot-Users] QE UEC driver compiler warnings...

[Dave Liu]

> qe.c: In function 'qe_upload_firmware':
> qe.c:390: warning: pointer targets in passing argument 2 of 'strcpy'
> differ in signedness
> uec.c: In function 'uec_initialize':
> uec.c:1236: warning: 'uec_info' may be used uninitialized in this
> function
> 
> 
> Please fix.  Thanks.

It's done, the patch is sent.
please apply it directly.

Thanks,
Dave

[U-Boot-Users] QE UEC driver compiler warnings...

[Timur Tabi]

Wolfgang Denk wrote:
> Dear Dave,
> 
> the QE UEC driver (in the top-of-tree version as of now) produces a
> few compiler warnings:
> 
> qe.c: In function 'qe_upload_firmware':
> qe.c:390: warning: pointer targets in passing argument 2 of 'strcpy' differ in signedness

That's odd, I've never seen that.  I'll post a patch to fix it.  FYI, this is 
not in the QE UEC driver, but in the QE library.

-- 
Timur Tabi
Linux kernel developer at Freescale

[U-Boot-Users] QE UEC driver compiler warnings...

[Wolfgang Denk]

In message <478CDF1A.3010207@freescale.com> you wrote:
> Wolfgang Denk wrote:
> > Dear Dave,
> > 
> > the QE UEC driver (in the top-of-tree version as of now) produces a
> > few compiler warnings:
> > 
> > qe.c: In function 'qe_upload_firmware':
> > qe.c:390: warning: pointer targets in passing argument 2 of 'strcpy' differ in signedness
> 
> That's odd, I've never seen that.  I'll post a patch to fix it.  FYI, this is 
> not in the QE UEC driver, but in the QE library.

Guess you're using older compilers, then. Try using GCC-4.2 if you
want to start some bigger cleanup now... ;-)

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Roses are red
Violets are blue
Some poems rhyme