[U-Boot-Users] resend#2 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver

Wolfgang Denk
2008-01-16T12:46:28Z

Dear Ben,
, the alignment is perfect. If it looked bad to you, i. e. if this is
what you saw:

in message <478D6D2A.5090608@gmail.com> you wrote:
>
> > +/* Ethernet Transmit and Receive Buffers */
> > +#define DBUF_LENGTH 1520
> > +#define PKT_MAXBUF_SIZE 1518
> > +#define PKT_MINBUF_SIZE 64
> > +#define PKT_MAXBLR_SIZE 1536
> >
> Please align better

Please don't get fooled. As you (probably) can see above, the
alignment is perfect. If it looked bad to you, i. e. if this is what
you saw:

> +/* Ethernet Transmit and Receive Buffers */
> +#define DBUF_LENGTH 1520
> +#define PKT_MAXBUF_SIZE 1518
> +#define PKT_MINBUF_SIZE 64
> +#define PKT_MAXBLR_SIZE 1536

...then this was caused by the fact that you did not see the code
alone, but with additional characters added at the beginning of the
line ("> +") - depending on where you are on a line, a TAB may or may
not get shifted then.

You have to *apply* the patch to really comment on formatting.

Best regards,

Wolfgang Denk

--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
CAUTION: The Mass of This Product Contains the Energy Equivalent of
85 Million Tons of TNT per Net Ounce of Weight.