[U-Boot-Users] resend #4: [PATCH 4/5]: add AcTux-3 board support

[Michael Schwingen <rincewind@discworld.dascon.de>]

Jean-Christophe PLAGNIOL-VILLARD wrote:
>> +void reset_phy (void)
>> +{
>> +	int i;
>> +
>> +	/* initialize the PHY */
>> +	miiphy_reset ("NPE0", CONFIG_PHY_ADDR);
>> +
>> +	/* all LED outputs = Link/Act */
>> +	miiphy_write ("NPE0", CONFIG_PHY_ADDR, 0x16, 0x0AAA);
>> +
>> +	/* set all ethernet switch ports to forwarding state */
>> +	for (i = 1; i <= 5; i++)
>> +		miiphy_write ("NPE0", CONFIG_PHY_ADDR + 8 + i, 0x04, 0x03);
>> +
>> +}
>>     
>
> Could you specify cleary in each baord file on which do you work 
???
> and
> please  be more explicit about his constants, rather than using magic
> numbers.
>   
The chip documentation is under NDA, so all I can do is hide away the 
constants by inventing useless names for them.

cu
Michael