From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Schwingen <rincewind@discworld.dascon.de>
Date: Wed, 16 Jan 2008 09:16:43 +0100
Subject: [U-Boot-Users] resend #4: [PATCH 4/5]: add AcTux-3 board	support
In-Reply-To: <20080116014137.GB31365@game.jcrosoft.org>
References: <20080115191249.GE27903@discworld.dascon.de>
	<20080116014137.GB31365@game.jcrosoft.org>
Message-ID: <478DBD6B.90501@discworld.dascon.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jean-Christophe PLAGNIOL-VILLARD wrote:
>> +void reset_phy (void)
>> +{
>> +	int i;
>> +
>> +	/* initialize the PHY */
>> +	miiphy_reset ("NPE0", CONFIG_PHY_ADDR);
>> +
>> +	/* all LED outputs = Link/Act */
>> +	miiphy_write ("NPE0", CONFIG_PHY_ADDR, 0x16, 0x0AAA);
>> +
>> +	/* set all ethernet switch ports to forwarding state */
>> +	for (i = 1; i <= 5; i++)
>> +		miiphy_write ("NPE0", CONFIG_PHY_ADDR + 8 + i, 0x04, 0x03);
>> +
>> +}
>>     
>
> Could you specify cleary in each baord file on which do you work 
???
> and
> please  be more explicit about his constants, rather than using magic
> numbers.
>   
The chip documentation is under NDA, so all I can do is hide away the 
constants by inventing useless names for them.

cu
Michael