* [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files
@ 2008-01-15 23:09 Timur Tabi
2008-01-16 0:43 ` Kim Phillips
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Timur Tabi @ 2008-01-15 23:09 UTC (permalink / raw)
To: u-boot
Remove the "#undef DEBUG" line from all Freescale 83xx board header files.
The inclusion of this line makes it impossible to enable debug code in
other source files, because "#define DEBUG" typically needs to be defined
before any header files are included.
Signed-off-by: Timur Tabi <timur@freescale.com>
---
Added MPC8360ERDK.h.
include/configs/MPC8323ERDB.h | 2 --
include/configs/MPC832XEMDS.h | 2 --
include/configs/MPC8349EMDS.h | 2 --
include/configs/MPC8360EMDS.h | 2 --
include/configs/MPC8360ERDK.h | 2 --
include/configs/MPC837XEMDS.h | 2 --
6 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/include/configs/MPC8323ERDB.h b/include/configs/MPC8323ERDB.h
index 4ea8709..0e33fce 100644
--- a/include/configs/MPC8323ERDB.h
+++ b/include/configs/MPC8323ERDB.h
@@ -9,8 +9,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H
-#undef DEBUG
-
/*
* High Level Configuration Options
*/
diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h
index 25ac58c..8cf0a5b 100644
--- a/include/configs/MPC832XEMDS.h
+++ b/include/configs/MPC832XEMDS.h
@@ -20,8 +20,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H
-#undef DEBUG
-
/*
* High Level Configuration Options
*/
diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h
index 437a9a5..2c6534c 100644
--- a/include/configs/MPC8349EMDS.h
+++ b/include/configs/MPC8349EMDS.h
@@ -29,8 +29,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H
-#undef DEBUG
-
/*
* High Level Configuration Options
*/
diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h
index fdacb90..310d03f 100644
--- a/include/configs/MPC8360EMDS.h
+++ b/include/configs/MPC8360EMDS.h
@@ -22,8 +22,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H
-#undef DEBUG
-
/*
* High Level Configuration Options
*/
diff --git a/include/configs/MPC8360ERDK.h b/include/configs/MPC8360ERDK.h
index 0f6f8f1..72d36c1 100644
--- a/include/configs/MPC8360ERDK.h
+++ b/include/configs/MPC8360ERDK.h
@@ -17,8 +17,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H
-#undef DEBUG
-
/*
* High Level Configuration Options
*/
diff --git a/include/configs/MPC837XEMDS.h b/include/configs/MPC837XEMDS.h
index 2b84e9c..61de084 100644
--- a/include/configs/MPC837XEMDS.h
+++ b/include/configs/MPC837XEMDS.h
@@ -21,8 +21,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H
-#undef DEBUG
-
/*
* High Level Configuration Options
*/
--
1.5.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files
2008-01-15 23:09 [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
@ 2008-01-16 0:43 ` Kim Phillips
2008-01-16 15:00 ` Timur Tabi
2008-01-16 1:57 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx boardheader files Liu Dave
2008-02-11 23:45 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Wolfgang Denk
2 siblings, 1 reply; 6+ messages in thread
From: Kim Phillips @ 2008-01-16 0:43 UTC (permalink / raw)
To: u-boot
On Tue, 15 Jan 2008 17:09:41 -0600
Timur Tabi <timur@freescale.com> wrote:
> Remove the "#undef DEBUG" line from all Freescale 83xx board header files.
> The inclusion of this line makes it impossible to enable debug code in
> other source files, because "#define DEBUG" typically needs to be defined
> before any header files are included.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> Added MPC8360ERDK.h.
>
> include/configs/MPC8323ERDB.h | 2 --
> include/configs/MPC832XEMDS.h | 2 --
> include/configs/MPC8349EMDS.h | 2 --
> include/configs/MPC8360EMDS.h | 2 --
> include/configs/MPC8360ERDK.h | 2 --
> include/configs/MPC837XEMDS.h | 2 --
> 6 files changed, 0 insertions(+), 12 deletions(-)
? Am I missing something? mpc83xx files aren't special in this area.
it appears to be a problem for a lot of boards:
include/configs/ads5121.h:#undef DEBUG
include/configs/AP1000.h:#undef DEBUG
include/configs/assabet.h:#undef DEBUG
include/configs/BAB7xx.h:#undef DEBUG
include/configs/EB+MCF-EV123.h:#undef DEBUG
include/configs/ELPPC.h:#undef DEBUG
include/configs/ep8248.h:#undef DEBUG
include/configs/ep82xxm.h:#undef DEBUG
include/configs/gcplus.h:#undef DEBUG
include/configs/gw8260.h:#undef DEBUG /* General debug */
include/configs/IPHASE4539.h:#undef DEBUG /* General debug */
include/configs/M5235EVB.h:#undef DEBUG
include/configs/M5271EVB.h:#undef DEBUG
include/configs/M5329EVB.h:#undef DEBUG
include/configs/M54455EVB.h:#undef DEBUG
include/configs/mgcoge.h:#undef DEBUG
include/configs/mpc7448hpc2.h:#undef DEBUG
include/configs/MPC8323ERDB.h:#undef DEBUG
include/configs/MPC832XEMDS.h:#undef DEBUG
include/configs/MPC8349EMDS.h:#undef DEBUG
include/configs/MPC8360EMDS.h:#undef DEBUG
include/configs/MPC8360ERDK.h:#undef DEBUG
include/configs/MPC837XEMDS.h:#undef DEBUG
include/configs/MPC8540EVAL.h:#undef DEBUG
include/configs/ms7722se.h:#undef DEBUG
include/configs/ms7750se.h:#undef DEBUG
include/configs/MVBLUE.h:#undef DEBUG
include/configs/ppmc7xx.h:#undef DEBUG
include/configs/QS823.h:#undef DEBUG /* debug output code */
include/configs/QS850.h:#undef DEBUG /* debug output code */
include/configs/QS860T.h:#undef DEBUG /* debug output code */
include/configs/Rattler.h:#undef DEBUG
include/configs/sacsng.h:#undef DEBUG /* General debug */
include/configs/sbc8260.h:#undef DEBUG /* General debug */
include/configs/sbc8349.h:#undef DEBUG
Kim
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files
2008-01-16 0:43 ` Kim Phillips
@ 2008-01-16 15:00 ` Timur Tabi
2008-01-16 16:30 ` Kim Phillips
0 siblings, 1 reply; 6+ messages in thread
From: Timur Tabi @ 2008-01-16 15:00 UTC (permalink / raw)
To: u-boot
Kim Phillips wrote:
> ? Am I missing something? mpc83xx files aren't special in this area.
> it appears to be a problem for a lot of boards:
I'm a Freescale employee (as are you), and so I'm not going to post a patch that
makes an untested changed to someone else's boards. And since 83xx is separate
from 85xx and 86xx, I have to keep the patches separate, too.
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files
2008-01-16 15:00 ` Timur Tabi
@ 2008-01-16 16:30 ` Kim Phillips
0 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2008-01-16 16:30 UTC (permalink / raw)
To: u-boot
On Wed, 16 Jan 2008 09:00:48 -0600
Timur Tabi <timur@freescale.com> wrote:
> I'm a Freescale employee (as are you), and so I'm not going to post a patch that
> makes an untested changed to someone else's boards. And since 83xx is separate
afaict, it's a trivial patch (minus the ads5121 which does a #define,
and an immediate #undef), and I haven't seen any objections to my
comment from the community.
> from 85xx and 86xx, I have to keep the patches separate, too.
WD applies the cross-arch/family patches directly.
Kim
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx boardheader files
2008-01-15 23:09 [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
2008-01-16 0:43 ` Kim Phillips
@ 2008-01-16 1:57 ` Liu Dave
2008-02-11 23:45 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Wolfgang Denk
2 siblings, 0 replies; 6+ messages in thread
From: Liu Dave @ 2008-01-16 1:57 UTC (permalink / raw)
To: u-boot
Timur,
Could you also remove it in the MPC8315ERDB.h in 83xx tree?
Thanks,
Dave
> -----Original Message-----
> From: u-boot-users-bounces at lists.sourceforge.net
> [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf
> Of Tabi Timur
> Sent: 2008?1?16? 7:10 AM
> To: Phillips Kim; u-boot-users at lists.sourceforge.net
> Cc: Tabi Timur
> Subject: [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from
> MPC83xx boardheader files
>
> Remove the "#undef DEBUG" line from all Freescale 83xx board
> header files.
> The inclusion of this line makes it impossible to enable debug code in
> other source files, because "#define DEBUG" typically needs
> to be defined
> before any header files are included.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> Added MPC8360ERDK.h.
>
> include/configs/MPC8323ERDB.h | 2 --
> include/configs/MPC832XEMDS.h | 2 --
> include/configs/MPC8349EMDS.h | 2 --
> include/configs/MPC8360EMDS.h | 2 --
> include/configs/MPC8360ERDK.h | 2 --
> include/configs/MPC837XEMDS.h | 2 --
> 6 files changed, 0 insertions(+), 12 deletions(-)
>
> diff --git a/include/configs/MPC8323ERDB.h
> b/include/configs/MPC8323ERDB.h
> index 4ea8709..0e33fce 100644
> --- a/include/configs/MPC8323ERDB.h
> +++ b/include/configs/MPC8323ERDB.h
> @@ -9,8 +9,6 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> -#undef DEBUG
> -
> /*
> * High Level Configuration Options
> */
> diff --git a/include/configs/MPC832XEMDS.h
> b/include/configs/MPC832XEMDS.h
> index 25ac58c..8cf0a5b 100644
> --- a/include/configs/MPC832XEMDS.h
> +++ b/include/configs/MPC832XEMDS.h
> @@ -20,8 +20,6 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> -#undef DEBUG
> -
> /*
> * High Level Configuration Options
> */
> diff --git a/include/configs/MPC8349EMDS.h
> b/include/configs/MPC8349EMDS.h
> index 437a9a5..2c6534c 100644
> --- a/include/configs/MPC8349EMDS.h
> +++ b/include/configs/MPC8349EMDS.h
> @@ -29,8 +29,6 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> -#undef DEBUG
> -
> /*
> * High Level Configuration Options
> */
> diff --git a/include/configs/MPC8360EMDS.h
> b/include/configs/MPC8360EMDS.h
> index fdacb90..310d03f 100644
> --- a/include/configs/MPC8360EMDS.h
> +++ b/include/configs/MPC8360EMDS.h
> @@ -22,8 +22,6 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> -#undef DEBUG
> -
> /*
> * High Level Configuration Options
> */
> diff --git a/include/configs/MPC8360ERDK.h
> b/include/configs/MPC8360ERDK.h
> index 0f6f8f1..72d36c1 100644
> --- a/include/configs/MPC8360ERDK.h
> +++ b/include/configs/MPC8360ERDK.h
> @@ -17,8 +17,6 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> -#undef DEBUG
> -
> /*
> * High Level Configuration Options
> */
> diff --git a/include/configs/MPC837XEMDS.h
> b/include/configs/MPC837XEMDS.h
> index 2b84e9c..61de084 100644
> --- a/include/configs/MPC837XEMDS.h
> +++ b/include/configs/MPC837XEMDS.h
> @@ -21,8 +21,6 @@
> #ifndef __CONFIG_H
> #define __CONFIG_H
>
> -#undef DEBUG
> -
> /*
> * High Level Configuration Options
> */
> --
> 1.5.2.4
>
>
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files
2008-01-15 23:09 [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
2008-01-16 0:43 ` Kim Phillips
2008-01-16 1:57 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx boardheader files Liu Dave
@ 2008-02-11 23:45 ` Wolfgang Denk
2 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2008-02-11 23:45 UTC (permalink / raw)
To: u-boot
In message <12004385814106-git-send-email-timur@freescale.com> you wrote:
> Remove the "#undef DEBUG" line from all Freescale 83xx board header files.
> The inclusion of this line makes it impossible to enable debug code in
> other source files, because "#define DEBUG" typically needs to be defined
> before any header files are included.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The net result is a system that is not only binary compatible with
4.3 BSD, but is even bug for bug compatible in almost all features."
- Avadit Tevanian, Jr., "Architecture-Independent Virtual Memory
Management for Parallel and Distributed Environments: The Mach
Approach"
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-02-11 23:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-15 23:09 [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
2008-01-16 0:43 ` Kim Phillips
2008-01-16 15:00 ` Timur Tabi
2008-01-16 16:30 ` Kim Phillips
2008-01-16 1:57 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx boardheader files Liu Dave
2008-02-11 23:45 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox