public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vlad Lungu <vlad@comsys.ro>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Target support for qemu -M mips
Date: Wed, 16 Jan 2008 19:20:07 +0200	[thread overview]
Message-ID: <478E3CC7.1020509@comsys.ro> (raw)
In-Reply-To: <478E01DA.8020506@ruby.dti.ne.jp>

Shinya Kuribayashi wrote:
> Dear Vlad,
>
> There are some coding style issues, but I'm fine with contents of the
> patch itself. Please find comments below and resubmit.
>
>
>   
My God, you are worse than ze germans! Sorry Wolfgang, I had to say it :-)

[snip]
> please update .lds to the latest board/dbau1x00/u-boot.lds, etc.
> I'd like to see
> 	. = .;
>   
What does this do ?
> 	_gp = ALIGN(16) + 0x7ff0;
> and
> 	.u_boot_cmd : {
> 	  __u_boot_cmd_start = .;
> 	  *(.u_boot_cmd)
> 	  __u_boot_cmd_end = .;
> 	}
> and so on. I understand it works well without such changes, but it's
> better to keep all target together.
>
>   
Any opinions on using a single ldscript per platform, eventually 
preprocessed with gcc -E to allow
for board-specific differences? At  least for MIPS, all scripts are 
essentally the same.
 

As for the style issues, some are mine, but many are in the code I 
copied from. Anyway, I fixed them. Patch to follow.

Regards,
Vlad

  reply	other threads:[~2008-01-16 17:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 11:54 [U-Boot-Users] Target support for qemu -M mips Vlad Lungu
2007-12-17 15:58 ` Shinya Kuribayashi
2007-12-17 16:52   ` Vlad Lungu
2007-12-22 15:03     ` [U-Boot-Users] [PATCH 1/1] qemu-mips: active HUSH PARSER, AUTO_COMPLETE and CMDLINE_EDITING Jean-Christophe PLAGNIOL-VILLARD
2008-01-04  3:16       ` Shinya Kuribayashi
2008-01-09 12:40       ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-09 15:34         ` Shinya Kuribayashi
2007-12-23  9:06     ` [U-Boot-Users] Target support for qemu -M mips Shinya Kuribayashi
2007-12-23 10:37       ` Jean-Christophe PLAGNIOL-VILLARD
2007-12-23 12:33         ` Vlad Lungu
2007-12-23 13:31           ` Shinya Kuribayashi
2008-01-16 13:08 ` Shinya Kuribayashi
2008-01-16 17:20   ` Vlad Lungu [this message]
2008-01-17  9:05     ` Shinya Kuribayashi
2008-01-17 11:10       ` Vlad Lungu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478E3CC7.1020509@comsys.ro \
    --to=vlad@comsys.ro \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox