From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Wed, 16 Jan 2008 17:16:54 -0500
Subject: [U-Boot-Users] ColdFire patches
In-Reply-To: <4791E710007FEB4BBF83775D787F462F05E89346@az33exm22.fsl.freescale.net>
References: Your message of "Tue, 15 Jan 2008 21:34:18 EST."
	<478D6D2A.5090608@gmail.com>	<20080116124628.43D236F0010@nyx.denx.de>
	<4791E710007FEB4BBF83775D787F462F05E8932B@az33exm22.fsl.freescale.net>
	<478E7C15.8030409@gmail.com>
	<4791E710007FEB4BBF83775D787F462F05E89346@az33exm22.fsl.freescale.net>
Message-ID: <478E8256.8090207@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Liew Tsi Chung wrote:
> Ben,
>
> 	Are you referring to fecdma_initialize() in
> drivers/net/fsl_mcdmafec.c and net/eth.c? If it is, the changes had
> applied. You and I agreed on last email that renamed to
> mcdmafec_initialize().
>   
In the new file, drivers/net/fsl_mcdmafec.c, most of the functions, such 
as setFecDuplexSpeed(), fec_send() and so on, are private to the driver 
(i.e. have file scope), and should be declared as static to avoid name 
space confusion.

In addition, the function name setFecDuplexSpeed() goes against the 
coding standard.  It should be set_fec_duplex_speed().

regards,
Ben