From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Wed, 16 Jan 2008 21:33:13 -0500
Subject: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x
 FEC	driver
In-Reply-To: <12005258853263-git-send-email-Tsi-Chung.Liew@freescale.com>
References: <12005258853263-git-send-email-Tsi-Chung.Liew@freescale.com>
Message-ID: <478EBE69.7080204@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tsi-Chung,

Tsi-Chung Liew wrote:
<snip>
> +
> +static int fec_send(struct eth_device *dev, volatile void *packet, int length);
> +static int fec_recv(struct eth_device *dev);
> +static int fec_init(struct eth_device *dev, bd_t * bd);
> +static void fec_halt(struct eth_device *dev);
>   
You don't need these prototypes.
> +extern int fecpin_setclear(struct eth_device *dev, int setclear);
> +
> +#ifdef CFG_DISCOVER_PHY
> +extern void mii_init(void);
> +extern uint mii_send(uint mii_cmd);
> +extern int mii_discover_phy(struct eth_device *dev);
> +extern int mcffec_miiphy_read(char *devname, unsigned char addr,
> +			      unsigned char reg, unsigned short *value);
> +extern int mcffec_miiphy_write(char *devname, unsigned char addr,
> +			       unsigned char reg, unsigned short value);
> +#endif
>   
There's no need to #ifdef prototypes, and the extern'ed ones are in 
header files that
you've included (or should be).

Since this patch relies on others in the series, it doesn' t make sense 
for me to apply it.

John, if the code compiles fine with these removed, please add this to 
the patch and apply:

Signed-off-by: Ben Warren <biggerbadderben@gmail.com>

Thanks very much for your contribution, Tsi-Chung.

regards,
Ben