[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[Nobuhiro Iwamatsu]

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/pcmcia/marubun_pcmcia.c b/drivers/pcmcia/marubun_pcmcia.c
index 7b112af..2479a66 100644
--- a/drivers/pcmcia/marubun_pcmcia.c
+++ b/drivers/pcmcia/marubun_pcmcia.c
@@ -25,11 +25,13 @@
 #include <pcmcia.h>
 #include <asm/io.h>
 
-#if	(CONFIG_COMMANDS & CFG_CMD_PCMCIA)
+#undef CONFIG_PCMCIA
+
+#if defined(CONFIG_CMD_PCMCIA)
 #define	CONFIG_PCMCIA
 #endif
 
-#if	(CONFIG_COMMANDS & CFG_CMD_IDE)
+#if	defined(CONFIG_CMD_IDE)
 #define	CONFIG_PCMCIA
 #endif
 
-- 
1.5.3.7

[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[Jon Loeliger]

On Tue, 2008-01-15 at 11:46, Nobuhiro Iwamatsu wrote:
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pcmcia/marubun_pcmcia.c b/drivers/pcmcia/marubun_pcmcia.c
> index 7b112af..2479a66 100644
> --- a/drivers/pcmcia/marubun_pcmcia.c
> +++ b/drivers/pcmcia/marubun_pcmcia.c
> @@ -25,11 +25,13 @@
>  #include <pcmcia.h>
>  #include <asm/io.h>
>  
> -#if	(CONFIG_COMMANDS & CFG_CMD_PCMCIA)
> +#undef CONFIG_PCMCIA
> +
> +#if defined(CONFIG_CMD_PCMCIA)
>  #define	CONFIG_PCMCIA
>  #endif
>  
> -#if	(CONFIG_COMMANDS & CFG_CMD_IDE)
> +#if	defined(CONFIG_CMD_IDE)
>  #define	CONFIG_PCMCIA
>  #endif
>  

Amen-brother-by: Jon Loeliger <jdl@freescale.com>


Oh, and, a "git grep CONFIG_COMMANDS" reveals that there
are a few other lingering instances of this bug around.

jdl

[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[Nobuhiro Iwamatsu]

2008/1/16, Jon Loeliger <jdl@freescale.com>:
> On Tue, 2008-01-15 at 11:46, Nobuhiro Iwamatsu wrote:
> > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > ---
> >  drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pcmcia/marubun_pcmcia.c b/drivers/pcmcia/marubun_pcmcia.c
> > index 7b112af..2479a66 100644
> > --- a/drivers/pcmcia/marubun_pcmcia.c
> > +++ b/drivers/pcmcia/marubun_pcmcia.c
> > @@ -25,11 +25,13 @@
> >  #include <pcmcia.h>
> >  #include <asm/io.h>
> >
> > -#if  (CONFIG_COMMANDS & CFG_CMD_PCMCIA)
> > +#undef CONFIG_PCMCIA
> > +
> > +#if defined(CONFIG_CMD_PCMCIA)
> >  #define      CONFIG_PCMCIA
> >  #endif
> >
> > -#if  (CONFIG_COMMANDS & CFG_CMD_IDE)
> > +#if  defined(CONFIG_CMD_IDE)
> >  #define      CONFIG_PCMCIA
> >  #endif
> >
>
> Amen-brother-by: Jon Loeliger <jdl@freescale.com>
>
>
> Oh, and, a "git grep CONFIG_COMMANDS" reveals that there
> are a few other lingering instances of this bug around.
Thank you for your comment.
# I have not understood "Amen-brother-by" first.

I found an mistake in my tree based on your point.

Thanks
 Nobuhiro

[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[Jon Loeliger]

Nobuhiro Iwamatsu wrote:
> 2008/1/16, Jon Loeliger <jdl@freescale.com>:
>> On Tue, 2008-01-15 at 11:46, Nobuhiro Iwamatsu wrote:
>>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>>> ---
>>>  drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
>>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/pcmcia/marubun_pcmcia.c b/drivers/pcmcia/marubun_pcmcia.c
>>> index 7b112af..2479a66 100644

>>>
>> Amen-brother-by: Jon Loeliger <jdl@freescale.com>
>>
>>
>> Oh, and, a "git grep CONFIG_COMMANDS" reveals that there
>> are a few other lingering instances of this bug around.

> Thank you for your comment.
> # I have not understood "Amen-brother-by" first.

Sorry.  It means "I _totally_ agree with this patch."
The religious word "Amen" means "Let it be" or "So be it".
By adding "Brother" to it, it makes it familiar, and
connotes charismatic religious fervor.  We should _all_
violently agree with this patch. :-)

> I found an mistake in my tree based on your point.

Atarashi pachi hoshii!

Fair is fair :-)

> Thanks
>  Nobuhiro

Thanks,
jdl

[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[Ben Warren]

Jon Loeliger wrote:
<snip>
> Sorry.  It means "I _totally_ agree with this patch."
> The religious word "Amen" means "Let it be" or "So be it".
> By adding "Brother" to it, it makes it familiar, and
> connotes charismatic religious fervor.  We should _all_
> violently agree with this patch. :-)
>
>   
Nothing like a violent 'amen' first thing in the morning!

B-)

[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[Nobuhiro Iwamatsu]

On Thu, 17 Jan 2008 08:50:05 -0600
Jon Loeliger <jdl@freescale.com> wrote:
> >> Oh, and, a "git grep CONFIG_COMMANDS" reveals that there
> >> are a few other lingering instances of this bug around.
> 
> > Thank you for your comment.
> > # I have not understood "Amen-brother-by" first.
> 
> Sorry.  It means "I _totally_ agree with this patch."
> The religious word "Amen" means "Let it be" or "So be it".
> By adding "Brother" to it, it makes it familiar, and
> connotes charismatic religious fervor.  We should _all_
> violently agree with this patch. :-)
Thank you for explaining. It is a good lesson for me.

> 
> > I found an mistake in my tree based on your point.
> 
> Atarashi pachi hoshii!
:-)
I sent patch that fix CONFIG_COMMANDS problem yesterday.

regards,
 Nobuhiro
-- 
Nobuhiro Iwamatsu

[U-Boot-Users] [PATCH] pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

[Jon Loeliger]

Nobuhiro Iwamatsu wrote:
>> We should _all_ violently agree with this patch. :-)
> Thank you for explaining. It is a good lesson for me.

No problem.

>> Atarashi pachi hoshii!
> :-)
> I sent patch that fix CONFIG_COMMANDS problem yesterday.

I saw that.  Thanks!

jdl