From: John Rigby <jrigby@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Update 5121 fdt support to match latest kernel work.
Date: Thu, 17 Jan 2008 09:01:43 -0700 [thread overview]
Message-ID: <478F7BE7.9020107@freescale.com> (raw)
In-Reply-To: <478F191C.9010703@semihalf.com>
address should be removed
local-mac-address will be added to the device tree when
I submit an ethernet patch so it should be left in u-boot.
Grzegorz Bernacki wrote:
> John Rigby wrote:
>
>> Based on reviews on the linuxppc-dev mailing list
>> some changes have been made to the device tree.
>> This patch updates u-boot to be in sync with those
>> changes.
>>
>> Signed-off-by: John Rigby <jrigby@freescale.com>
>> ---
>> cpu/mpc512x/cpu.c | 2 --
>> include/configs/ads5121.h | 6 +++---
>> 2 files changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/cpu/mpc512x/cpu.c b/cpu/mpc512x/cpu.c
>> index 6421a51..793b62a 100644
>> --- a/cpu/mpc512x/cpu.c
>> +++ b/cpu/mpc512x/cpu.c
>> @@ -138,10 +138,8 @@ void ft_cpu_setup(void *blob, bd_t *bd)
>>
>> do_fixup_by_path_u32(blob, cpu_path, "timebase-frequency", OF_TBCLK, 1);
>> do_fixup_by_path_u32(blob, cpu_path, "bus-frequency", bd->bi_busfreq, 1);
>> - do_fixup_by_path_u32(blob, cpu_path, "ref-frequency", CFG_MPC512X_CLKIN, 1);
>> do_fixup_by_path_u32(blob, cpu_path, "clock-frequency", bd->bi_intfreq, 1);
>> do_fixup_by_path_u32(blob, "/" OF_SOC, "bus-frequency", bd->bi_ipsfreq, 1);
>> - do_fixup_by_path_u32(blob, "/" OF_SOC, "ref-frequency", CFG_MPC512X_CLKIN, 1);
>> do_fixup_by_path(blob, eth_path, "address", bd->bi_enetaddr, 6, 0);
>> do_fixup_by_path(blob, eth_path, "local-mac-address", bd->bi_enetaddr, 6, 0);
>>
> [snip]
>
> What about "address" and "local-mac-address"? I cannot find it in device tree, I think you should removed it also.
>
> regards,
> Grzesiek
>
>
prev parent reply other threads:[~2008-01-17 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 22:52 [U-Boot-Users] [PATCH] Update 5121 fdt support to match latest kernel work John Rigby
2008-01-17 9:00 ` Grzegorz Bernacki
2008-01-17 16:01 ` John Rigby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478F7BE7.9020107@freescale.com \
--to=jrigby@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox