From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Thu, 17 Jan 2008 13:36:04 -0500 Subject: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver In-Reply-To: <4791E710007FEB4BBF83775D787F462F05E89588@az33exm22.fsl.freescale.net> References: <12005258853263-git-send-email-Tsi-Chung.Liew@freescale.com> <478EBE69.7080204@gmail.com> <4791E710007FEB4BBF83775D787F462F05E8956F@az33exm22.fsl.freescale.net> <478F9E10.6090307@gmail.com> <4791E710007FEB4BBF83775D787F462F05E89588@az33exm22.fsl.freescale.net> Message-ID: <478FA014.1080200@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Liew Tsi Chung wrote: > Ben, > > >> Right, so there's no need to mention them in C code. Less is >> more, as they say. >> > Agree. > > So, everything ok now? > > I haven't seen the patch that removes the prototypes, but it's quite possible I looked past it. In a previous e-mail I added a 'signed-off-by' that John Rigby can add to the patch commit. I consider this to be a Coldfire patch because it's dependent on other patches in the series and I have no way of testing it. I hope that's OK. regards, Ben > Regards, > TsiChung > > -----Original Message----- > From: Ben Warren [mailto:biggerbadderben at gmail.com] > Sent: Thursday, January 17, 2008 12:27 PM > To: Liew Tsi Chung > Cc: U-Boot-Users; Wolfgang Denx; Rigby John > Subject: Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add > MCF547x_8x FEC driver > > Liew Tsi Chung wrote: > >> Ben, >> >> The prototypes have place in include/asm-m68k/fsl_mcdmafec.h. >> >> Regards, >> TsiChung >> >> >> > Right, so there's no need to mention them in C code. Less is more, as > they say. > > regards, > Ben > >