public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v2 2/2] Implement hard SPI driver on MPC8349EMDS
Date: Thu, 17 Jan 2008 14:06:57 -0500	[thread overview]
Message-ID: <478FA751.3060909@gmail.com> (raw)
In-Reply-To: <20080117124457.2698c05f.kim.phillips@freescale.com>

Kim Phillips wrote:
> On Wed, 16 Jan 2008 22:37:42 -0500
> Ben Warren <biggerbadderben@gmail.com> wrote:
>
>   
>> +void spi_eeprom_chipsel(int cs)
>> +{
>> +	volatile gpio83xx_t *iopd = &((immap_t *)CFG_IMMR)->gpio[0];
>> +
>> +	if(cs)
>>     
>
> s/if(/if (/
>
> unless no-one else has any objections, this should probably go in
> before the window closes.
>
> Kim
>
>   
I was just about to respond to your other message to ask if you'd have 
time to fit it in. Do you want me to resend patches or can you apply 
yourself (since you already have the handy diff). Either way's fine by me.

regards,
Ben

  reply	other threads:[~2008-01-17 19:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17  3:37 [U-Boot-Users] [PATCH v2 2/2] Implement hard SPI driver on MPC8349EMDS Ben Warren
2008-01-17 18:44 ` Kim Phillips
2008-01-17 19:06   ` Ben Warren [this message]
2008-01-17 19:28     ` Kim Phillips
2008-01-17 19:35       ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478FA751.3060909@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox