public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mpc83xx: Correct the struct spi8xxx in mpc8xxx_spi.h
Date: Thu, 17 Jan 2008 22:09:24 -0500	[thread overview]
Message-ID: <47901864.5030100@gmail.com> (raw)
In-Reply-To: <1200622024.3654.3.camel@localhost.localdomain>

Dave Liu wrote:
> The commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb
> cause the 83xx immap broken, so the DMA and PCI will
> be failed.
>
> The patch fix the struct spi8xxx.
>
> Signed-off-by: Dave Liu <daveliu@freescale.com>
> ---
>  include/asm-ppc/immap_83xx.h  |    4 ++--
>  include/asm-ppc/mpc8xxx_spi.h |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/asm-ppc/immap_83xx.h b/include/asm-ppc/immap_83xx.h
> index c16a098..023d725 100644
> --- a/include/asm-ppc/immap_83xx.h
> +++ b/include/asm-ppc/immap_83xx.h
> @@ -388,14 +388,14 @@ typedef struct lbus83xx {
>   * Serial Peripheral Interface
>   */
>  typedef struct spi83xx {
> +	u8 res0[0x20];
>  	u32 mode;		/* mode register */
>  	u32 event;		/* event register */
>  	u32 mask;		/* mask register */
>  	u32 com;		/* command register */
> -	u8 res0[0x10];
>  	u32 tx;			/* transmit register */
>  	u32 rx;			/* receive register */
> -	u8 res1[0xFD8];
> +	u8 res1[0xFC8];
>  } spi83xx_t;
>  
>   
BTW - this one isn't used anywhere.  We should probably remove it from 
this file.  Not urgent, though.

regards,
Ben

  reply	other threads:[~2008-01-18  3:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18  2:07 [U-Boot-Users] [PATCH] mpc83xx: Correct the struct spi8xxx in mpc8xxx_spi.h Dave Liu
2008-01-18  3:09 ` Ben Warren [this message]
2008-01-18 18:49   ` Kim Phillips
2008-01-18 19:02     ` Ben Warren
2008-01-18 19:43       ` [U-Boot-Users] U-Boot versions k b
2008-01-18 20:06         ` Jerry Van Baren
2008-01-18 22:19           ` k b
2008-01-19  0:03             ` gvb.uboot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47901864.5030100@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox