From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Tue, 22 Jan 2008 12:55:52 -0600
Subject: [U-Boot-Users] [PATCH v3] QE IO: Add initial data to pin
 configuration + read/write functions
In-Reply-To: <B27D27F93BC429468DBC3B0DA043AA4401C65C7B@ilptex01.ecitele.com>
References: <B27D27F93BC429468DBC3B0DA043AA4401BE0DB7@ILPTEX02.ecitele.com>
	<478F92C9.8030205@freescale.com>
	<B27D27F93BC429468DBC3B0DA043AA4401C65C7B@ilptex01.ecitele.com>
Message-ID: <47963C38.4010205@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

David Saada wrote:
> Any feedback on this patch? Timur?

It looks okay, but I haven't had a chance to review it thoroughly.

I don't like the value of "2" for "ignore".  Since that type is an 'int', how 
about using "-1" instead?

-- 
Timur Tabi
Linux kernel developer at Freescale