From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Wed, 23 Jan 2008 10:40:20 -0500 Subject: [U-Boot-Users] [PATCH 6/6] [new uImage] Move FDT error printing to common fdt_error() routine In-Reply-To: <20080123150035.25280.62015.stgit@zion.izotz.org> References: <20080123144325.25280.18839.stgit@zion.izotz.org> <20080123150035.25280.62015.stgit@zion.izotz.org> Message-ID: <47975FE4.5060308@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Marian Balakowicz wrote: > FDT error handling in PPC do_bootm_linux() shares the same message format. > This patch moves error message printing to a helper fdt_error() routine. > > Signed-off-by: Marian Balakowicz > --- > > lib_ppc/bootm.c | 50 ++++++++++++++++++++++++-------------------------- > 1 files changed, 24 insertions(+), 26 deletions(-) [snip] > @@ -310,8 +306,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, > > of_flat_tree = (char *)image_get_load (fdt_hdr); > } else { > - puts ("Did not find a flat Flat Device Tree.\n" > - "Must RESET the board to recover.\n"); > + fdt_error ("Did not find a flat Flat Device Tree"); Ouch, I messed that one up pretty badly in the original. Should be "Did not find a Flattened Device Tree" s/flat Flat/Flattened/ [snip] > #endif > #ifdef CONFIG_OF_HAS_BD_T > if (fdt_bd_t(of_flat_tree) < 0) { > - puts ("ERROR: /bd_t node create failed - " > - "must RESET the board to recover.\n"); > + fdte_error ("/bd_t node create failed"); Typo s/fdte_error/fdt_error/ [snip] FWIIW, with the above changes... Acked-by: Gerald Van Baren Good improvement, thanks. gvb