public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] latest (1.3.1) doesn't compile: Makefile issue
Date: Wed, 23 Jan 2008 14:16:44 -0600	[thread overview]
Message-ID: <4797A0AC.4030407@freescale.com> (raw)
In-Reply-To: <2308fb0f0801231115l57eaa4edj37eb950bc9c30343@mail.gmail.com>

Tales Toledo wrote:
> Hi
> 
> I saw a previous discussion but I think main reason why 1.3.1 doesn't
> compile is different from mentioned there.
> I had the same error trying to compile to EP88x with eldk 3.1 toolchains.
> 
> It seems that /common/Makefile conditional CONFIG_CMD_FLASH isn't working fine.
> It should be set at previous configuration files like config.mk but it
> is just set at header files.
> 
> I just change the line as follow I got it work.
> 
> #COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o
> COBJS-y += cmd_flash.o
> 
> I'm not familiar with this new Makefile style since I have used old
> u-boot versions.
> Any help to make this work properly is appreciated.
> 

The line you commented-out is the _new_ U-Boot
Makefile style.  Expect much, much more of it!

If your port needs the cmd_flash file, then you
need to ensure that CONFIG_CMD_FLASH is #define'd
in your port config .h file.  Then, ensure that it
is also appearing in the autoconf.mk file after it
is generated too.

jdl

  reply	other threads:[~2008-01-23 20:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 19:15 [U-Boot-Users] latest (1.3.1) doesn't compile: Makefile issue Tales Toledo
2008-01-23 20:16 ` Jon Loeliger [this message]
2008-01-24 18:40   ` Tales Toledo
2008-01-24 23:17     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4797A0AC.4030407@freescale.com \
    --to=jdl@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox