From: "Heiko Stübner" <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/4] fdtdec: protect against another NULL phandlep in fdtdec_add_reserved_memory()
Date: Fri, 08 Nov 2019 15:50:48 +0100 [thread overview]
Message-ID: <4798247.DyQcYcuMpC@diego> (raw)
In-Reply-To: <20191023144641.5710-1-heiko@sntech.de>
Am Mittwoch, 23. Oktober 2019, 16:46:38 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The change adding fdtdec_add_reserved_memory() already protected the added
> phandle against the phandlep being NULL - making the phandlep var optional.
>
> But in the early code checking for an already existing carveout this check
> was not done and thus the phandle assignment could run into trouble,
> so add a check there as well, which makes the function still return
> successfully if a matching region is found, even though no-one wants to
> work with the phandle.
>
> Fixes: c9222a08b3f7 ("fdtdec: Implement fdtdec_add_reserved_memory()")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
this patch already received in v2 a
Reviewed-by: Simon Glass <sjg@chromium.org>
next prev parent reply other threads:[~2019-11-08 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 14:46 [U-Boot] [PATCH v3 1/4] fdtdec: protect against another NULL phandlep in fdtdec_add_reserved_memory() Heiko Stuebner
2019-10-23 14:46 ` [U-Boot] [PATCH v3 2/4] fdtdec: only create phandle if caller wants it " Heiko Stuebner
2019-11-08 14:51 ` Heiko Stübner
2019-11-14 13:42 ` sjg at google.com
2019-11-14 13:43 ` sjg at google.com
2019-10-23 14:46 ` [U-Boot] [PATCH v3 3/4] image: fdt: copy possible optee nodes to a loaded devicetree Heiko Stuebner
2019-11-14 13:43 ` Simon Glass
2019-10-23 14:46 ` [U-Boot] [PATCH v3 4/4] tests: add OP-TEE test suite Heiko Stuebner
2019-11-08 14:51 ` Heiko Stübner
2019-11-14 13:42 ` sjg at google.com
2019-11-14 13:43 ` sjg at google.com
2019-11-08 14:50 ` Heiko Stübner [this message]
2019-11-14 13:43 ` [U-Boot] [PATCH v3 1/4] fdtdec: protect against another NULL phandlep in fdtdec_add_reserved_memory() sjg at google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4798247.DyQcYcuMpC@diego \
--to=heiko@sntech.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox